Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exlly.com HACKED #236

Closed
EXLLY opened this issue Jan 20, 2019 · 42 comments
Closed

exlly.com HACKED #236

EXLLY opened this issue Jan 20, 2019 · 42 comments

Comments

@EXLLY
Copy link

EXLLY commented Jan 20, 2019

Hello

We have been the victim of add balance for Bitcoin and Litecoin in wallet of the exchange platform but no deposit for the Bitcoin or Litecoin on servers.

At all 100 Litecoin and 200 Bitcoin. We are trying to retrieve the IP address of the user.
But there was no balance for withdrawals. We lanching Exlly in 2019.

we have deactivated withdrawals and we are currently sending emails to users with real funds to withdraw them.

we will close the platform.

It is urgent to fix this problem in the source code or to warn that the code is hacked.

https://exlly.com/

@sayyidkaelani
Copy link

after i sent my addres on email will my fund be sent to my wallet or do you take my money away?

@EXLLY
Copy link
Author

EXLLY commented Jan 21, 2019

We sent you an email to return your funds yesterday. We asked you for a Bitcoin address, for your deposit, but we received an address in Litecoin. We do not "leave with the funds". We are all the more sorry about what is happening and our priority is to protect our uses of which you are a part.

@jonn4y
Copy link
Contributor

jonn4y commented Jan 21, 2019

"It is urgent to fix this problem in the source code or to warn that the code is hacked."

despite numerous security experts reviewing the code the dev still claims the code is safe, you are now the 5th exchange that I know of that has been hacked this way. funny how the only exchange that doesn't get hacked is the devs.

stay clear of opentrade, he refuses to update and fix any bugs to the public release and we have been given a list of vulnerabilities by security experts

@3s3s
Copy link
Owner

3s3s commented Jan 21, 2019

Nobody has shown any vulnerabilities in the published code yet.
I only see common words like: "sql injection". But no one showed an exploit.
It is difficult to catch a black cat in a dark room, especially when it is not there.

@altmarkets
Copy link

when what's not there?

@3s3s
Copy link
Owner

3s3s commented Jan 21, 2019

Where is it? Are you got an exploit or not?

@sourcefinder1986
Copy link

Hi Enmanet,
I tried that what you said and it is NOT working.

@sourcefinder1986
Copy link

On which platform?
I tried it myself on our system and I cannot get any increase in balance....

@3s3s
Copy link
Owner

3s3s commented Jan 21, 2019

Impossible.
User is locked whein closing an order
g_LockExchange[userID]['lock'] = true;
https://github.com/3s3s/opentrade/blob/master/server/modules/users/orders.js#L65

After this order amount updated to 0
await g_constants.dbTables['orders'].Update("amount='0.0', time='"+Date.now()+"'", WHERE_ORDER);
https://github.com/3s3s/opentrade/blob/master/server/modules/users/orders.js#L93

Only then user balance is updating and user is unlocked
https://github.com/3s3s/opentrade/blob/master/server/modules/users/orders.js#L106

If the user will try to close the same order again then balance will not change because
const newBalance = utils.roundDown(balance[0].balance*1 + fullAmount);
https://github.com/3s3s/opentrade/blob/master/server/modules/users/orders.js#L87

where

const fullAmount = order.buysell == 'buy' ? utils.roundDown(order.amount*order.price+g_constants.share.TRADE_COMISSION*order.amount*order.price) :
utils.roundDown(order.amount*1);

https://github.com/3s3s/opentrade/blob/master/server/modules/users/orders.js#L75

but order.amount is already 0.

@sourcefinder1986
Copy link

I tried it now for half an hour and it is not possible to hack it for me.

@ExchangeTime
Copy link

@3s3s the problem isnt in the trading. I know how to do the glitch. Its the withdraw / coupon problem. Incase you try to withdraw high amounts etc when you dont have anything multiple times you sometimes get the amount credited to the account.

@ExchangeTime
Copy link

I will look into the code, but its something with the withdraw that gives you back.

If you have 0.1 btc and tries to withdraw 200 you end up with 199.9 btc on the account with no withdraw. Than you make the withdraw when you have 200 btc as normal.

@3s3s
Copy link
Owner

3s3s commented Jan 21, 2019

Ok, its up to you to believe it or not.

Have a nice day!

Edit:
The problem is not closing orders, its letting an attacker create multiple orders at the same time, and all are identical. Just lock opening orders once the first order is created, and set a time to wait until they can create a new one.

User is locked when adding new order here
g_LockExchange[status.id]['lock'] = true;
https://github.com/3s3s/opentrade/blob/master/server/modules/users/orders.js#L331

After that, the user balance is updated
https://github.com/3s3s/opentrade/blob/master/server/modules/users/orders.js#L336

then order inserted and only then user is unlocked
https://github.com/3s3s/opentrade/blob/master/server/modules/users/orders.js#L355

I am not see any way: how the user can place multiply orders without the balance updating (

@3s3s
Copy link
Owner

3s3s commented Jan 21, 2019

There are so many security vulnerabilities in OpenTrade code which needs to be fixed. Dev must update code or one have to rewrite entire code.
If dev not interested in update of code then one can fork this code ask for pull request if any has fixes.

Dev will happy to update the code if anyone will show an exploit.
So far, I only see the theoretical talk

@sourcefinder1986
Copy link

sourcefinder1986 commented Jan 21, 2019

i totally agree with 3s3s and i am happy that he released open trade to us and that he still works on it and comments all the questions here.

who knows if hack wasnt done from inside the vps...
because when you do transactions in the wallet via vps / daemon it shows weird balances on the exchange....

@EXLLY
Copy link
Author

EXLLY commented Jan 21, 2019

Hello

I have some fix for OpenTrade, to use smtp with SSL. Also there are a redirection problem for pin code or alert for mail confirmation. Support email confirmation. Email from for support. But I haven’t fix for add balance issue.
I will make pull request soon.

Thank you to all for considering this problem and working on this. It’s really important to have a good code without breach.

@altmarkets
Copy link

bitmxithickz do you really think we're using that exchange script - It's merely based on binance (its an exchange if you havent heard of it) the only relevance is the small featured banners at top.

The various exploits are easily due to how bloaty and bad the code is.

@jonn4y
Copy link
Contributor

jonn4y commented Jan 22, 2019

What a fucking idiot

@multicoins
Copy link

The various exploits are easily due to how bloaty and bad the code is.

You got exploits but you will not show it? Hmm. It is interesting...

@multicoins
Copy link

@ExchangeTime Have you tried coupon withdraw successfully amount more than user balance with non-admin account?

Only Admin (userid=1) can withdraw more than he got on account balance
https://github.com/3s3s/opentrade/blob/master/server/modules/users/wallet.js#L514

This is not bug. This is feature.

@jonn4y
Copy link
Contributor

jonn4y commented Jan 22, 2019

We don’t have exploits
We hired external security experts to review the code after the hack, they provided information on various vunerabilites, we deemed it more work than it’s worth to continue using opentrade and moved on to a better system

@jonn4y
Copy link
Contributor

jonn4y commented Jan 22, 2019

lol im just going to leave you here to argue with yourself if you are not smart enough to know what we are using for our exchange now then you clearly know as much as I thought you did when you told people you fixed all security issues in opentrade yet I don't see any push requests from you either.
please dont tag me in here again, github issues isnt a bitching forum its a place to post bugs

@knkrth knkrth mentioned this issue Jan 22, 2019
@PuNkYsHuNgRy
Copy link

PuNkYsHuNgRy commented Jan 22, 2019

I'm confused. I was looking into using this software. Is there an issue or not? Also if there is an issue can you point me to another backend issue free?

@altmarkets
Copy link

You are aware that around 10-15 exchanges have been hacked using OT, and the well aware fact that the dev has pretty made now made it closed source since since he's a 9 year old, yet you wish to use it?

@3s3s
Copy link
Owner

3s3s commented Jan 23, 2019

You can use OpenTrade as an exchange template only
It is very simply to install and configure the OpenTrade however, this does not mean that OpenTrade is ready to use crypto exchange for newbies.
You should closely review the code before placing it in production. You must be sure of safety your VDS servers. And of course you must be 100% sure of the integrity of your admins.

@3s3s 3s3s closed this as completed Jan 23, 2019
@altmarkets
Copy link

altmarkets commented Feb 10, 2019 via email

@ExchangeTime
Copy link

@altmarkets Kinda funny how you refounded coins without any value at all and same day all admins left the discord and all channels was fucked up with all connection been removed. You exit scammed and blame others.

@jonn4y
Copy link
Contributor

jonn4y commented Feb 10, 2019

how did we exit scam you fucking idiot, if we did we wouldn't be here now, we also refunded btc, doge and x42 too, no admins left the discord we are still there. believe what you want to believe and have a nice day. P.S. its refunded*

@altmarkets
Copy link

@altmarkets Kinda funny how you refounded coins without any value at all and same day all admins left the discord and all channels was fucked up with all connection been removed. You exit scammed and blame others.

What.

We refunded, all the TX ID's are public too, All admins were not removed - we're still online, active within the discord. Stop going on about something you clearly have no idea about, as i said - join the discord, contact us - we'll show you we have full transparency.

@ExchangeTime
Copy link

Great word vocabulary, using "fucking idiot". Thats a proof that you are afraid as you wouldnt have left the discord and fucked all channels up same day as it happend. Keep up with your bullshit and good luck with your 2nd scam project at same domain.

@IMPERIUM-main-dev
Copy link

I'm the guy as in the movies.... sitting in the corner.... seems like he's reading a newspaper.... don't see the face.... never say a word...... but listens.

@ghost
Copy link

ghost commented Feb 25, 2019

And i'm his brother. Drunk. At the bar.

@ghost
Copy link

ghost commented Feb 25, 2019

let's see what happens with altmarkets.io this time........ altmarkets.cc listed me for 3 days and I paid a bit but still..... I really would like to hope we were wrong. But I just can't believe it.

@ghost
Copy link

ghost commented Feb 25, 2019

Because I asked them to list my new coin, and they insulted me.

@altmarkets
Copy link

We're the normal people - above you. Thinking, he's back look.

@ghost
Copy link

ghost commented Feb 25, 2019

lollll

@ghost
Copy link

ghost commented Feb 25, 2019

yeah I should retire

@ghost
Copy link

ghost commented Feb 25, 2019

and play pokemon

@altmarkets
Copy link

People do realise that your talking to yourself right, you need to look into that. It's an issue. People know LightningCash and Imerium are from the same 'developer'.

You paid $35 to list a coin (which is no longer functional) , that was via .cc also we refused to list your new coin - you also pretended to be "CIA" - need to grow up a little and move along.

@Firoz81
Copy link

Firoz81 commented Apr 25, 2019

Hi, @jonn4y @altmarkets,

I want to start my own crypto exchange, I gave a try on opentrade and I guess it's easy to set up. but this hack things and vulnerabilities in code maybe big issue. You guys said opentrade code has security vulnerabilities but you did not revealed where, also did not explore your hack story how exactly it was hacked? I know you opentrade guys are intelligent and honest while we all here are idiots but if you explain what exactly happen dev may fix that bug and this code maybe usable for all.
I know you guys are code geeks even smarter than opentrade dev but we would like to know how exchange was hacked so we can work on code to fix.

You guys are hard coders and 3s3s is noob but please let all know how exchange was hacked and help 3s3s fix bugs you found or your external experts who also must be more smarter and intelligent than you.
So kindly explore how hacker hacked?

Thank You.

@picscoin
Copy link

What are you stupid or something? is this thing hackable ? I am about to dos the entire universe! Can u haz my bitcoin or what? It's not like someone deleting all teamspeak channels or anything like that would mean consipiracy or abuse from staff? So are staff compliant or no?

@picscoin
Copy link

Where is the sql portion is this thing needing sql or not? how can sql injection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests