Rework the SnapshotCache #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test of different packages access the internal structure of the snapshot cache to validate behavior. This causes a lot of work each time the internal structure of the snapshot cache changes in upstream go-control-plane. This commit reworks the cache to make use of new funcions in go-control-plane that make it easier to write/read to/from the cache and confines any access to the internal structure to the pkg/discoveryservice/xdss/v3 package.
3scale-robot
added
kind/feature
3scale-robot
added
size/L
|
/ok-to-test |
3scale-robot
added
the
ok-to-test
|
/lgtm black magic |
|
LGTM label has been added. Git tree hash: 99ec1ae8307740895ba8b3a306cb5a1e65047ce1
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests of different packages access the internal structure of the snapshot cache to validate correct behaviour. This causes a lot of work each time the internal structure of the snapshot cache changes in upstream go-control-plane repo. This PR reworks the cache to make use of new funcions in go-control-plane that make it easier to write/read to/from the cache and confines any access to the internal structure to just the pkg/discoveryservice/xdss/v3 package.
/kind feature
/priority important-longterm
/assign