-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make spec.envoyResources[*].name optional #152
Conversation
/lgtm |
LGTM label has been added. Git tree hash: d728e237be132d4c306c4704a28a0b464fa868dc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raelga The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
After the changes in #145 the name field is irrelevant and has no effect. This PR makes this field optional. The field will be removed in a future release.
/kind cleanup
/kind documentation
/priority important-soon
/assign