Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make spec.envoyResources[*].name optional #152

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Make spec.envoyResources[*].name optional #152

merged 2 commits into from
Oct 24, 2022

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Oct 24, 2022

After the changes in #145 the name field is irrelevant and has no effect. This PR makes this field optional. The field will be removed in a future release.

/kind cleanup
/kind documentation
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 24, 2022
@3scale-robot 3scale-robot added size/M Requires about a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 24, 2022
@slopezz
Copy link
Member

slopezz commented Oct 24, 2022

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d728e237be132d4c306c4704a28a0b464fa868dc

raelga
raelga approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@3scale-robot 3scale-robot merged commit 3af760d into main Oct 24, 2022
@3scale-robot 3scale-robot deleted the name-is-optional branch October 24, 2022 10:53
@roivaz
Copy link
Member Author

roivaz commented Oct 24, 2022

/ok-to-test

@roivaz roivaz added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga approved these changes

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roivaz @slopezz @3scale-robot @raelga