-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement secrets controller as an event handler #149
Conversation
…gRevision controller
/ok-to-test |
0052d68
to
663ff57
Compare
663ff57
to
49649e5
Compare
/lgtm |
LGTM label has been added. Git tree hash: cead62d02eaae1fc472a51a35446dba3f7d13104
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The secrets controller that watched certificates has been re-implemented as an event handler in the EnvoyConfigRevision controller, which is the proper way to do it. The old secrets controller was code required for it to work with pre 1.0 operator-sdk releases.
/kind feature
/priority important-longterm
/assign