Auto renew ca certificate #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
the
kind/feature
3scale-robot
added
the
priority/important-longterm
3scale-robot
added
needs-size
|
closes #22 |
roivaz
force-pushed
the
auto-renew-ca-certificate
branch
from
d364a04
to
a670d62
Compare
roivaz
commented
Oct 19, 2022
Comment on lines
+99
to
143
| // IssuerChangedHandler returns an EventHandler that generates | ||
| // reconcile requests for Secrets | ||
| func (r *DiscoveryServiceCertificateReconciler) IssuerChangedHandler() handler.EventHandler { | ||
| return handler.EnqueueRequestsFromMapFunc( | ||
| func(o client.Object) []reconcile.Request { | ||
|
|
||
| issuer := o.(*operatorv1alpha1.DiscoveryServiceCertificate) | ||
| // Only interested in changes to CA certificates. A change in the CA | ||
| // means that the child certificates need to be re-issued | ||
| if !issuer.IsCA() { | ||
| return []reconcile.Request{} | ||
| } | ||
|
|
||
| list := &operatorv1alpha1.DiscoveryServiceCertificateList{} | ||
| if err := r.Client.List(context.Background(), list); err != nil { | ||
| return []reconcile.Request{} | ||
| } | ||
|
|
||
| reconcileRequests := []reconcile.Request{} | ||
|
|
||
| for _, dsc := range list.Items { | ||
| if dsc.Spec.Signer.CASigned != nil && | ||
| dsc.Spec.Signer.CASigned.SecretRef.Name == issuer.Spec.SecretRef.Name { | ||
|
|
||
| reconcileRequests = append(reconcileRequests, | ||
| reconcile.Request{NamespacedName: types.NamespacedName{ | ||
| Name: dsc.GetName(), | ||
| Namespace: dsc.GetNamespace(), | ||
| }}) | ||
| } | ||
| } | ||
|
|
||
| return reconcileRequests | ||
| }, | ||
| ) | ||
| } | ||
|
|
||
| // SetupWithManager adds the controller to the manager | ||
| func (r *DiscoveryServiceCertificateReconciler) SetupWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewControllerManagedBy(mgr). | ||
| For(&operatorv1alpha1.DiscoveryServiceCertificate{}). | ||
| Owns(&corev1.Secret{}). | ||
| Watches(&source.Kind{Type: &operatorv1alpha1.DiscoveryServiceCertificate{}}, r.IssuerChangedHandler()). | ||
| Complete(r) | ||
| } |
There was a problem hiding this comment.
this is the important part, all other changes are just cleanup
|
/lgtm |
|
LGTM label has been added. Git tree hash: 4a148b8628515c0a75fad0196f2dea607bd8be59
|
|
/ok-to-test |
3scale-robot
added
the
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new event handler in the DiscoveryServiceCertificate controller to trigger a reconcile of any certificate that has its issuer certificate modified. After this, it is safe to enable auto-renewal of the discovery service CA certificate.
/kind feature
/assign
/priority important-longterm
Note for reviewers: #149 needs to be merged first and then I will rebase.