-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Add redis twemproxy dashboard #200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
kind/feature
Categorizes issue or PR as related to a new feature.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
needs-size
Indicates a PR or issue lacks a `size/foo` label and requires one.
size/XL
Requires about a week to complete the PR or the issue.
labels
May 16, 2022
3scale-robot
removed
the
needs-size
Indicates a PR or issue lacks a `size/foo` label and requires one.
label
May 16, 2022
Awesome job. |
LGTM label has been added. Git tree hash: bd65d5ca888db6ec51d73cb2d8de411a6f859355
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slopezz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
size/XL
Requires about a week to complete the PR or the issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #196
Adds redisshard controller suite testing (was one of the few controllers without testing)
Simplifies grafana dashboard resource by getting all defined keys directly (not necessary struct data)
Adds a whole new twemproxy grafana dashboard
TwemproxyConfig controller is the only one permitting N CustomResources on the same namespace (all the other controllers harcode resources names), where on TwemproxyConfig CR it is used directly the
InstanceName
to create the expected target ConfigMapInstanceName
+-twemproxy
(to not have collision between different CRs fighting for the resource name), although the dashboard content is exactly the same, and the same information can be extracted for any deployment with twemproxy metrics in any of the created dashboardsInstanceName
+-twemproxy
(grafana-operator uses the internal title in the json file, so need to be also unique for every GrafanaDashboard CR)TwemproxyConfig controller cannot be checked with ginkgo framework, because it needs more than a k8s API, it needs to connects to sentinel instances (which are connected to redis instances). For this reason, it has been added a simple e2e testing with kuttl tool:
kind-deploy
target, the external APIs need to be created before executing the kustomize (and vaildate they are available at API level), because for the specific case of prometheusServiceMonitor
, thekind-deploy
target was failing because once created the ServiceMonitor CRD, it was still not available at API level (Wait for a CRD type to deploy before deploying resources that use the type kubernetes/kubectl#1117) , but kustomize was trying to create the saas-operator ServiceMonitor failing with:/kind feature
/priority important-soon
/assign