-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/dev/openshift #297
Merged
Merged
feat/dev/openshift #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a022ae3
to
6196a42
Compare
/retitle feat/dev/openshift |
This avoids having to hardcode values in the Makefile. It's also a more portable approach. The downside is that it requires installation of tekton within kind.
So far this config was hardcoded in the system config files
raelga
approved these changes
May 6, 2024
LGTM label has been added. Git tree hash: 74267bbaf444e57b9b820dcbfa97ed087dc1d896
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
size/XL
Requires about a week to complete the PR or the issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several features that improve the local-setup to make it usable also in a publicly accessible Openshift cluster:
override
option was only usable in a local environment because secrets shouldn't be hard coded in a setup where the endpoints are published to the internet. Example usage:saas-operator/config/local-setup/workloads/backend.yaml
Lines 2 to 20 in 3c91c7e
saas-operator/config/local-setup/workloads/system.yaml
Lines 115 to 164 in 3c91c7e
local-setup kustomize config hard coded secrets have been removed. The user of the config is now expected to provide a file with the secret values. Check https://github.com/3scale-ops/saas-operator/blob/feat/dev/openshift/config/local-setup/README.md for more instructions.
github actions have been upgraded
Several options have been added to the System CR so domains can be properly configured via the CR.
/kind feature
/priority important-soon
/assign