Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #838 - removed unnecessary comma #840

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix #838 - removed unnecessary comma #840

merged 1 commit into from
Jul 11, 2023

Conversation

dzabel
Copy link

@dzabel dzabel commented Jul 10, 2023

@dzabel dzabel requested a review from a team as a code owner July 10, 2023 09:55
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

Hi @dzabel. Thanks for your PR.

I'm waiting for a 3scale member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eguzki
eguzki previously approved these changes Jul 10, 2023
@eguzki eguzki dismissed their stale review July 10, 2023 11:42

tests not passing

@codeclimate
Copy link

codeclimate bot commented Jul 10, 2023

Code Climate has analyzed commit c070379 and detected 0 issues on this pull request.

View more on Code Climate.

@eguzki
Copy link
Member

eguzki commented Jul 10, 2023

/ok-to-test

@eguzki eguzki merged commit 055724e into 3scale:master Jul 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus rule clarification
3 participants