Pathrouting fix #1190
Merged
Pathrouting fix #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to update the unit tests. For example here we are passing an empty table. There are a few instances of this in the unit test, would be nice to add a test for both the happy and unhappy paths. |
eloycoto
reviewed
May 6, 2020
| @@ -17,7 +17,7 @@ function _M.find_service(config_store, host) | |||
| if hosts[h] == host then | |||
| local name = service.system_name or service.id | |||
| ngx.log(ngx.DEBUG, 'service ', name, ' matched host ', hosts[h]) | |||
| local matches = mapping_rules_matcher.matches(method, uri, {}, service.rules) | |||
| local matches = mapping_rules_matcher.matches(method, uri, ngx.req.get_uri_args(), service.rules) | |||
There was a problem hiding this comment.
This is ok, but I would move this to the top. Calling to a function is expensive, and we should be worried about.
Do the same as method, uri, etc..
eloycoto
approved these changes
May 19, 2020
eloycoto
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix THREESCALE-5149