[t] test that path routing works with HTTPS #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
ssl_certificate_path_routing
branch
from
b04710a
to
668ff41
Compare
mayorova
reviewed
Dec 4, 2018
mikz
force-pushed
the
ssl_certificate_path_routing
branch
from
668ff41
to
4d804a3
Compare
mayorova
approved these changes
Dec 4, 2018
|
Thanks a lot for taking the time to implement a test and explain the fix ! Very appreciated ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test to verify claims in #938 (comment).
@nmasse-itix this PR adds a test that verifies path routing still works with HTTPS.