-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenTracing configurability #141
Conversation
With the current implementation the OpenTracing configuration is being provided with a |
Ready for a first review @eguzki before I proceed to do some verifications |
45e0ac7
to
8fd2ee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
f9c721b
to
cdc8e8e
Compare
@eguzki I think this should be ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
minor comments dropped
cdc8e8e
to
a00e8cf
Compare
a00e8cf
to
721375d
Compare
This exposes OpenTracing functionality provided by APIcast into the APIcast operator.
Design
A new
spec.openTracing
section has been added in theAPIcast
CR.An example:
openTracing
section are optionalenabled
flag is not specified, it defaults tofalse
tracingLibrary
flag is not specified, it defaults tojaeger
tracingConfigRef
flag is not specified, it defaults to a default tracing configuration specific to the settracingLirary
. This default tracing configuration is provided in the APIcast image itselfThe configuration is mounted into the APIcast pod by looking at a
config
key in the provided secret name and mounted in/opt/app-root/src/tracing-configs/tracing-config-<tracing_library_name>-<secret_name>
, for example inopt/app-root/src/tracing-configs/tracing-config-jaeger-mysecretname
Pending: