Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant location block "client_secret_matches" #129

Closed
mpguerra opened this issue Nov 10, 2016 · 3 comments
Closed

Redundant location block "client_secret_matches" #129

mpguerra opened this issue Nov 10, 2016 · 3 comments
Assignees
@mikz
Labels
A-OAuth2

Comments

@mpguerra
Copy link
Contributor

In apicast.conf there is a client_secret_matches location block that is not currently used or needed:

https://github.com/3scale/apicast/blob/c306f49655caa6cae98479ff53fad41afd1b57ea/apicast/conf.d/apicast.conf#L121-L127
@mikz mikz mentioned this issue Nov 10, 2016
Merged
@mikz mikz self-assigned this Nov 10, 2016
@andrewdavidmackenzie
Copy link
Member

Thanks Pili.... keep polishing it!

@mikz
Copy link
Contributor

mikz commented Nov 10, 2016

Next time you can just edit it from github ;) Might be easier than creating an issue.

@mpguerra
Copy link
Contributor Author

Thanks, I will next time, I was just shy about it ;)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikz mikz

Labels
A-OAuth2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikz @davidor @mpguerra @andrewdavidmackenzie