Non-blocking Redis calls: optimize pipelines by flushing just once #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires need to be reordered to add the method to the RESP class after it has been defined.
unleashed
approved these changes
Mar 6, 2019
🔫 🔪 very reluctantly ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves performance by making sure that we only call .write on the underlying socket just once per pipeline instead of per command.
Pipelines are not implemented in async-redis so we need to add the patch in our codebase. The idea is to contribute the pipelines functionality to the async-redis lib at some point.
Notice that the base branch of this PR is the
asyncintegration branch, not master.