Non-blocking Redis calls: run tests with both blocking/non-blocking drivers #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
reviewed
Apr 9, 2019
davidor
force-pushed
the
tests-with-sync-and-async-storage
branch
from
883e354
to
2819ed4
Compare
Update to latest 2.3.x, which is the version included in our dev and CI images.
davidor
force-pushed
the
tests-with-sync-and-async-storage
branch
from
2819ed4
to
e91edb1
Compare
unleashed
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work started in #77
It just adapts
script/testto run all the tests with both blocking/non-blocking storage drivers. The reason is that we'll need both for some time.Notice that the base branch of this PR is the integration branch
async, notmaster.Note: CircleCI fails because the CI image contains a ruby version that is not compatible with this feature (async lib requires ruby >= 2.2.7).