PF content background, header & card look & feel

[thomasmaas]

Still lots of things to fix but to get an idea of the amount of work needed. This was done in 3 hours.

[mcoker]

Hey @thomasmaas, from looking at the screenshots, this looks great overall! Not sure the intended scope of the POC, but a few bits of feedback:

• I might just verify that the header icons are 16x16 (or 16px on the longer edge)
• We don't support the footer at the bottom of the content area.
• For the card box shadow, we use 0 1px 2px 0 rgba(3, 3, 3, 0.2);. Let me know if you'd like for me to look at anything in more detail.
• Our blue link text color is #06c. Looks like the blue text here is a slightly lighter shade?

Let me know if you'd like me to look at anything in more detail.

[thomasmaas]

Thanks @mcoker,

It will be a CSS-only pull request so footer removal will be out of scope. I believe I'm using the correct box shadow. Will look into blue and icon sizes but we are still using a system that scales with window size so there is no such thing as 16x16 px in current 3scale design.

[codecov]

Codecov Report

Merging #1182 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1182      +/-   ##
==========================================
- Coverage   93.15%   93.13%   -0.02%     
==========================================
  Files        2511     2512       +1     
  Lines       83167    83266      +99     
==========================================
+ Hits        77471    77552      +81     
- Misses       5696     5714      +18

Impacted Files	Coverage Δ
.../initializers/backport_pg_10_support_to_rails_4.rb	30% <0%> (-50%)	⬇️
config/initializers/postgres.rb	50% <0%> (-50%)	⬇️
config/initializers/access_token_authentication.rb	55.55% <0%> (-22.23%)	⬇️
app/models/application_record.rb	66.66% <0%> (-13.89%)	⬇️
app/queries/new_accounts_query.rb	71.73% <0%> (-10.87%)	⬇️
app/lib/three_scale/api/responder.rb	95.74% <0%> (-2.13%)	⬇️
lib/tasks/impersonation_admin_user.rake	90% <0%> (ø)	⬆️
spec/acceptance/api/user_spec.rb	100% <0%> (ø)
lib/tasks/multitenant/tenants.rake	67.92% <0%> (+11.32%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b298e6...f65afa4. Read the comment docs.

[thomasmaas]

Invoice pages look off. Seems they need more horizontal padding/white border https://multitenant-admin.preview01.3scale.net/finance/invoices/682198789

[damianpm]

Invoice pages look off. Seems they need more horizontal padding/white border https://multitenant-admin.preview01.3scale.net/finance/invoices/682198789

@thomasmaas I've updated invoices page

[thomasmaas]

Groups form looks off: https://multitenant-admin.preview01.3scale.net/buyers/accounts/2445581507739/groups

[thomasmaas]

Integration page is pretty broken (for no apiap):
https://diamondbackenergy-admin.preview01.3scale.net/apiconfig/services/2555417827279/integration#proxy