Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding grey backgrounds, white boxes and aligning items #1237

Conversation

damianpm
Copy link
Contributor

@damianpm damianpm commented Sep 24, 2019

What this PR does / why we need it:

It continues with the implementation of visual context for PF4 cards, tables and lists initiated in #1182

Which issue(s) this PR fixes

https://issues.jboss.org/browse/THREESCALE-3448

Please browse in all pages you can

01

02

03

04

05

06

07

08

10

11

12

13

@damianpm damianpm force-pushed the THREESCALE-3448-Visual-Context-PF4 branch from 4a48fe8 to 88518e9 Compare September 24, 2019 16:03
@damianpm damianpm changed the base branch from master to content-bg-and-cards-proof-of-concept September 24, 2019 16:20
@damianpm damianpm changed the base branch from content-bg-and-cards-proof-of-concept to master September 24, 2019 16:20
@damianpm damianpm changed the base branch from master to content-bg-and-cards-proof-of-concept September 24, 2019 16:42
@damianpm damianpm force-pushed the THREESCALE-3448-Visual-Context-PF4 branch from 88518e9 to a90c47b Compare September 24, 2019 16:49
@damianpm damianpm marked this pull request as ready for review September 24, 2019 17:01
@josemigallas

This comment has been minimized.

@josemigallas

This comment has been minimized.

@josemigallas

This comment has been minimized.

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #1237 into content-bg-and-cards-proof-of-concept will decrease coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           content-bg-and-cards-proof-of-concept    #1237     +/-   ##
========================================================================
- Coverage                                  92.55%   91.66%   -0.9%     
========================================================================
  Files                                       2457     2325    -132     
  Lines                                      80171    74674   -5497     
========================================================================
- Hits                                       74205    68448   -5757     
- Misses                                      5966     6226    +260
Impacted Files Coverage Δ
app/lib/logic/nginx_proxy.rb 27.27% <0%> (-72.73%) ⬇️
app/helpers/support_entitlements_helper.rb 33.33% <0%> (-66.67%) ⬇️
app/lib/three_scale/email_sanitizer.rb 25% <0%> (-66.67%) ⬇️
lib/range_hacks.rb 37.5% <0%> (-62.5%) ⬇️
app/lib/events/importers/first_traffic_importer.rb 40% <0%> (-60%) ⬇️
app/queries/auto_account_deletion_queries.rb 40% <0%> (-60%) ⬇️
app/workers/purge_old_user_sessions_worker.rb 40% <0%> (-60%) ⬇️
app/models/numeric_hash.rb 41.17% <0%> (-58.83%) ⬇️
app/helpers/google_experiments_helper.rb 28.57% <0%> (-57.15%) ⬇️
...orkers/service_discovery/refresh_service_worker.rb 44.44% <0%> (-55.56%) ⬇️
... and 326 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6315676...fc4af3a. Read the comment docs.

@damianpm damianpm force-pushed the THREESCALE-3448-Visual-Context-PF4 branch from 26214f9 to 7abfe97 Compare September 25, 2019 14:55
@damianpm damianpm force-pushed the THREESCALE-3448-Visual-Context-PF4 branch from 7abfe97 to 2a5c3a4 Compare September 25, 2019 15:07
@josemigallas

This comment has been minimized.

@josemigallas

This comment has been minimized.

@josemigallas

This comment has been minimized.

@damianpm damianpm force-pushed the THREESCALE-3448-Visual-Context-PF4 branch 7 times, most recently from cb94770 to 7633501 Compare September 26, 2019 12:54
@damianpm damianpm force-pushed the THREESCALE-3448-Visual-Context-PF4 branch 2 times, most recently from 01f60df to 41635a3 Compare September 26, 2019 14:04
@damianpm damianpm force-pushed the THREESCALE-3448-Visual-Context-PF4 branch from 41635a3 to fc4af3a Compare September 27, 2019 14:47
@damianpm damianpm merged this pull request into content-bg-and-cards-proof-of-concept Oct 1, 2019
@damianpm damianpm deleted the THREESCALE-3448-Visual-Context-PF4 branch October 1, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants