New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding grey backgrounds, white boxes and aligning items #1237
Merged
damianpm
merged 4 commits into
content-bg-and-cards-proof-of-concept
from
THREESCALE-3448-Visual-Context-PF4
Oct 1, 2019
Merged
Adding grey backgrounds, white boxes and aligning items #1237
damianpm
merged 4 commits into
content-bg-and-cards-proof-of-concept
from
THREESCALE-3448-Visual-Context-PF4
Oct 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianpm
force-pushed
the
THREESCALE-3448-Visual-Context-PF4
branch
from
September 24, 2019 16:03
4a48fe8
to
88518e9
Compare
damianpm
changed the base branch from
master
to
content-bg-and-cards-proof-of-concept
September 24, 2019 16:20
damianpm
changed the base branch from
content-bg-and-cards-proof-of-concept
to
master
September 24, 2019 16:20
damianpm
changed the base branch from
master
to
content-bg-and-cards-proof-of-concept
September 24, 2019 16:42
damianpm
force-pushed
the
THREESCALE-3448-Visual-Context-PF4
branch
from
September 24, 2019 16:49
88518e9
to
a90c47b
Compare
…3448-Visual-Context-PF4
thomasmaas
reviewed
Sep 25, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## content-bg-and-cards-proof-of-concept #1237 +/- ##
========================================================================
- Coverage 92.55% 91.66% -0.9%
========================================================================
Files 2457 2325 -132
Lines 80171 74674 -5497
========================================================================
- Hits 74205 68448 -5757
- Misses 5966 6226 +260
Continue to review full report at Codecov.
|
damianpm
force-pushed
the
THREESCALE-3448-Visual-Context-PF4
branch
from
September 25, 2019 14:55
26214f9
to
7abfe97
Compare
damianpm
force-pushed
the
THREESCALE-3448-Visual-Context-PF4
branch
from
September 25, 2019 15:07
7abfe97
to
2a5c3a4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
damianpm
force-pushed
the
THREESCALE-3448-Visual-Context-PF4
branch
7 times, most recently
from
September 26, 2019 12:54
cb94770
to
7633501
Compare
damianpm
force-pushed
the
THREESCALE-3448-Visual-Context-PF4
branch
2 times, most recently
from
September 26, 2019 14:04
01f60df
to
41635a3
Compare
damianpm
force-pushed
the
THREESCALE-3448-Visual-Context-PF4
branch
from
September 27, 2019 14:47
41635a3
to
fc4af3a
Compare
josemigallas
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It continues with the implementation of visual context for PF4 cards, tables and lists initiated in #1182
Which issue(s) this PR fixes
https://issues.jboss.org/browse/THREESCALE-3448
Please browse in all pages you can