[Refactor] Remove: Gem parallel_tests & Some unused cukes tags and steps. #1418

Martouta · 2019-11-15T12:09:41Z

Closes THREESCALE-3467 - Remove selenium tag from cucumber
Closes THREESCALE-3929 - Remove parallel_tests Gem

Remove gem parallel_tests.
[Cukes] Remove Selenium & Alert tags.
Remove env MULTIJOB_KIND and for CI use CIRCLE_NODE_INDEX.
[Cukes] Remove fakeweb tag.
Remove Tasks::Integration.
[Cukes] Remove JS helper and JS steps.
[Cukes] Remove some unused alert steps.

codecov · 2019-11-18T15:17:42Z

Codecov Report

Merging #1418 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1418      +/-   ##
=========================================
- Coverage   92.95%   92.7%   -0.25%     
=========================================
  Files        2429    2388      -41     
  Lines       80338   76828    -3510     
=========================================
- Hits        74675   71222    -3453     
+ Misses       5663    5606      -57

Impacted Files	Coverage Δ
...hentication_provider/service_discovery_provider.rb	`44.44% <0%> (-55.56%)`	⬇️
...ib/developer_portal/lib/liquid/drops/pagination.rb	`54.76% <0%> (-36.91%)`	⬇️
...esenters/service_discovery_oauth_flow_presenter.rb	`50% <0%> (-25%)`	⬇️
...lib/three_scale/oauth2/service_discovery_client.rb	`52.08% <0%> (-22.92%)`	⬇️
lib/developer_portal/lib/liquid/drops/i18n.rb	`82.6% <0%> (-17.4%)`	⬇️
...rvice_discovery/authentication_provider_support.rb	`85.71% <0%> (-14.29%)`	⬇️
app/lib/service_discovery/controller_methods.rb	`81.25% <0%> (-12.5%)`	⬇️
app/controllers/api/services_controller.rb	`83.75% <0%> (-3.75%)`	⬇️
app/lib/three_scale/oauth2/client.rb	`97.36% <0%> (-2.64%)`	⬇️
app/controllers/api/integrations_controller.rb	`66.23% <0%> (-11.84%)`	⬇️
... and 289 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b79d8...88254de. Read the comment docs.

config/cucumber.yml

guicassolato · 2019-11-26T10:20:13Z

Gemfile.base

@@ -206,7 +206,6 @@ group :test do
  gem 'webmock', '~> 2.3.2'
  gem 'launchy'
  gem 'mechanize'
-  gem 'parallel_tests', '~> 2.3'


Can this affect https://github.com/3scale/porta/tree/master/lib/tasks/integration.rake?

I don't know how that works but that is for CircleCI, right? and CircleCI is passing all tests in this PR because it does not use parallel_tests. In fact we are not using it anymore for anything.
Btw, I assume you mean only the parts that I haven't remove from that rake 😄

We can remove it it was for jenkins
And migrating to Rails 6 we can have it back natively

@hallelujah What do u mean? part of the changes u requested before were in that file for CircleCI, so I cannot remove the whole file, can I? 😕
EDIT: Apparently we can 👍

features/support/hooks.rb

lib/tasks/integration.rake

spec/rails_helper.rb

hallelujah · 2019-11-29T11:48:32Z

features/support/helpers/javascript_helper.rb

-        return true;
-      }")
-  end
-
  def last_javascript_alert


We do not need this anymore I think either

hallelujah · 2019-11-29T11:52:59Z

lib/tasks/integration.rake

@@ -61,7 +61,7 @@ namespace :integrate do
      test_dirs = resolve_test_groups_by_path

      {
-        :cucumber_javascript => 'parallel_cucumber --verbose features -o "-b -p parallel --tags=@javascript --tags=~@fakeweb --tags=~@percy --tags=~@ignore"',
+        :cucumber_javascript => 'parallel_cucumber --verbose features -o "-b -p parallel --tags=@javascript --tags=~@percy --tags=~@ignore"',


All those parallel are not needed anymore

In fact the whole rake integrate is not needed anymore

…eps. - Remove gem parallel_tests. - [Cukes] Remove Selenium & Alert tags. - Remove env MULTIJOB_KIND and for CI use env CIRCLE_NODE_INDEX. - [Cukes] Remove fakeweb tag. - Remove Tasks::Integration. - [Cukes] Remove JS helper and JS steps. - [Cukes] Remove some unused alert steps.

Martouta self-assigned this Nov 15, 2019

Martouta force-pushed the THREESCALE-3467-remove-selenium-tag branch from 84a0aef to b253601 Compare November 15, 2019 13:26

Martouta changed the title ~~[WIP][Cukes] Remove @selenium tag~~ [WIP] Remove gems Selenium and ParallelTasks Nov 15, 2019

Martouta force-pushed the THREESCALE-3467-remove-selenium-tag branch 2 times, most recently from a97f5cd to fdee9d9 Compare November 18, 2019 11:59

Martouta changed the title ~~[WIP] Remove gems Selenium and ParallelTasks~~ [WIP] Remove selenium tag from cucumber + Remove parallel_tests Gem Nov 18, 2019

Martouta force-pushed the THREESCALE-3467-remove-selenium-tag branch 2 times, most recently from bf1f329 to b506f98 Compare November 18, 2019 15:17

Martouta marked this pull request as ready for review November 18, 2019 15:38

Martouta requested review from hallelujah, duduribeiro, guicassolato and macejmic November 18, 2019 15:39

Martouta changed the title ~~[WIP] Remove selenium tag from cucumber + Remove parallel_tests Gem~~ Remove selenium tag from cucumber + Remove parallel_tests Gem Nov 18, 2019

Martouta force-pushed the THREESCALE-3467-remove-selenium-tag branch from b506f98 to 515ce43 Compare November 18, 2019 16:00

hallelujah reviewed Nov 18, 2019

View reviewed changes

config/cucumber.yml Show resolved Hide resolved

Martouta changed the title ~~Remove selenium tag from cucumber + Remove parallel_tests Gem~~ [WIP] Remove selenium tag from cucumber + Remove parallel_tests Gem Nov 18, 2019

Martouta force-pushed the THREESCALE-3467-remove-selenium-tag branch 2 times, most recently from 3cf2853 to 88254de Compare November 26, 2019 05:51

Martouta changed the title ~~[WIP] Remove selenium tag from cucumber + Remove parallel_tests Gem~~ Remove selenium tag from cucumber + Remove parallel_tests Gem Nov 26, 2019

Martouta requested review from hallelujah and a team November 26, 2019 05:57

macejmic previously approved these changes Nov 26, 2019

View reviewed changes

guicassolato reviewed Nov 26, 2019

View reviewed changes

Martouta requested a review from guicassolato November 28, 2019 13:01

hallelujah reviewed Nov 28, 2019

View reviewed changes

features/support/hooks.rb Outdated Show resolved Hide resolved

features/support/hooks.rb Outdated Show resolved Hide resolved

lib/tasks/integration.rake Show resolved Hide resolved

Martouta changed the title ~~Remove selenium tag from cucumber + Remove parallel_tests Gem~~ [WIP] Remove selenium tag from cucumber + Remove parallel_tests Gem Nov 28, 2019

Martouta dismissed macejmic’s stale review via 18c2c4e November 28, 2019 13:40

Martouta force-pushed the THREESCALE-3467-remove-selenium-tag branch from 9c54449 to 18c2c4e Compare November 28, 2019 13:40

Martouta changed the title ~~[WIP] Remove selenium tag from cucumber + Remove parallel_tests Gem~~ Remove selenium tag from cucumber + Remove parallel_tests Gem Nov 28, 2019

Martouta requested review from hallelujah and macejmic November 28, 2019 14:19

hallelujah previously approved these changes Nov 28, 2019

View reviewed changes

hallelujah reviewed Nov 28, 2019

View reviewed changes

spec/rails_helper.rb Outdated Show resolved Hide resolved

Martouta changed the title ~~Remove selenium tag from cucumber + Remove parallel_tests Gem~~ [WIP] Remove selenium tag from cucumber + Remove parallel_tests Gem Nov 28, 2019

Martouta dismissed hallelujah’s stale review via 5a053be November 28, 2019 14:49

Martouta changed the title ~~[WIP] Remove selenium tag from cucumber + Remove parallel_tests Gem~~ Remove selenium tag from cucumber + Remove parallel_tests Gem Nov 28, 2019

Martouta requested review from hallelujah and a team November 28, 2019 14:50

hallelujah reviewed Nov 29, 2019

View reviewed changes

Martouta changed the title ~~Remove selenium tag from cucumber + Remove parallel_tests Gem~~ [WIP] Remove selenium tag from cucumber + Remove parallel_tests Gem Nov 29, 2019

Martouta force-pushed the THREESCALE-3467-remove-selenium-tag branch from 5a053be to bfecf1e Compare November 29, 2019 12:18

Martouta requested a review from hallelujah November 29, 2019 12:18

Martouta changed the title ~~[WIP] Remove selenium tag from cucumber + Remove parallel_tests Gem~~ [WIP] [Refactor] Remove: Gem parallel_tests & Some unused cukes tags and steps. Nov 29, 2019

Martouta changed the title ~~[WIP] [Refactor] Remove: Gem parallel_tests & Some unused cukes tags and steps.~~ [Refactor] Remove: Gem parallel_tests & Some unused cukes tags and steps. Nov 29, 2019

hallelujah approved these changes Nov 29, 2019

View reviewed changes

Martouta merged commit 4f15b36 into master Nov 29, 2019

Martouta deleted the THREESCALE-3467-remove-selenium-tag branch November 29, 2019 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Refactor] Remove: Gem parallel_tests & Some unused cukes tags and steps. #1418

[Refactor] Remove: Gem parallel_tests & Some unused cukes tags and steps. #1418

Martouta commented Nov 15, 2019 •

edited

Loading

codecov bot commented Nov 18, 2019 •

edited

Loading

guicassolato Nov 26, 2019

Martouta Nov 28, 2019 •

edited

Loading

hallelujah Nov 29, 2019

Martouta Nov 29, 2019 •

edited

Loading

hallelujah Nov 29, 2019

hallelujah Nov 29, 2019

[Refactor] Remove: Gem parallel_tests & Some unused cukes tags and steps. #1418

[Refactor] Remove: Gem parallel_tests & Some unused cukes tags and steps. #1418

Conversation

Martouta commented Nov 15, 2019 • edited Loading

codecov bot commented Nov 18, 2019 • edited Loading

Codecov Report

guicassolato Nov 26, 2019

Choose a reason for hiding this comment

Martouta Nov 28, 2019 • edited Loading

Choose a reason for hiding this comment

hallelujah Nov 29, 2019

Choose a reason for hiding this comment

Martouta Nov 29, 2019 • edited Loading

Choose a reason for hiding this comment

hallelujah Nov 29, 2019

Choose a reason for hiding this comment

hallelujah Nov 29, 2019

Choose a reason for hiding this comment

Martouta commented Nov 15, 2019 •

edited

Loading

codecov bot commented Nov 18, 2019 •

edited

Loading

Martouta Nov 28, 2019 •

edited

Loading

Martouta Nov 29, 2019 •

edited

Loading