-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Endpoint Provider ProxyConfig List #2201
Merged
Martouta
merged 4 commits into
master
from
THREESCALE-4528-proxy_config-API-performance
Oct 13, 2020
Merged
API Endpoint Provider ProxyConfig List #2201
Martouta
merged 4 commits into
master
from
THREESCALE-4528-proxy_config-API-performance
Oct 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martouta
force-pushed
the
THREESCALE-4528-proxy_config-API-performance
branch
12 times, most recently
from
October 13, 2020 08:41
5b3b1d1
to
ee5f8f1
Compare
Martouta
changed the title
[WIP] [DO NOT REVIEW] API Endpoint Provider ProxyConfig List
[WIP] API Endpoint Provider ProxyConfig List
Oct 13, 2020
Martouta
commented
Oct 13, 2020
Martouta
added
feature
A new feature of the product
on hold
Waiting for or blocked by something else.
ruby
Pull requests that update Ruby code
labels
Oct 13, 2020
Martouta
force-pushed
the
THREESCALE-4528-proxy_config-API-performance
branch
3 times, most recently
from
October 13, 2020 10:04
332093b
to
12716f8
Compare
Martouta
force-pushed
the
THREESCALE-4528-proxy_config-API-performance
branch
from
October 13, 2020 11:46
12716f8
to
192cfb2
Compare
To help me test: @tenants = Account.tenants.last(2).to_a
def make_pcs(service, number)
proxy = service.proxy
return if proxy.proxy_configs.count >= number
number.times do
proxy.proxy_configs.create!(environment: ProxyConfig::ENVIRONMENTS.sample, content: ({ proxy: { hosts: ['example.com']}}.to_json))
end
end
@tenants.each do |t|
t.services.each do |s|
begin
ServiceCreator.new(service: s).call(private_endpoint: BackendApi.default_api_backend)
rescue ThreeScale::Core::APIClient::ConnectionError, ThreeScale::Core::APIClient::JSONError
end
make_pcs(s, 30)
end
end |
Better for adding/changing endpoints in a similar way to the other endpoints of proxy configs.
Martouta
force-pushed
the
THREESCALE-4528-proxy_config-API-performance
branch
from
October 13, 2020 16:06
192cfb2
to
7d5e1fd
Compare
macejmic
reviewed
Oct 13, 2020
macejmic
previously approved these changes
Oct 13, 2020
Martouta
changed the title
[WIP] API Endpoint Provider ProxyConfig List
API Endpoint Provider ProxyConfig List
Oct 13, 2020
macejmic
approved these changes
Oct 13, 2020
Martouta
added
the
Priority: Blocker
This PR is a blocker. Everyone should review and help to close it ASAP.
label
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
A new feature of the product
Priority: Blocker
This PR is a blocker. Everyone should review and help to close it ASAP.
ruby
Pull requests that update Ruby code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of THREESCALE-4528
Depends on the other PRs of the issue.
APIcast needs to fetch all proxy configs of a provider and doing so by fetching first all its services (just for its IDs) and then doing an API request to proxy configs for each service is just a too slow approach.