Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content for Quickstarts guides #2919

Merged
merged 38 commits into from Apr 27, 2022
Merged

Conversation

dfennessy
Copy link
Collaborator

Done for THREESCALE-8187

Copy link
Member

@junezhang junezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Darren, I just reviewed the templated.yaml file, but I haven't found the real content after the seven titles, when we click the sub-title, we only see the demo content like the screenshot of what paste above.

app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
@dfennessy
Copy link
Collaborator Author

Hi, Darren, I just reviewed the templated.yaml file, but I haven't found the real content after the seven titles, when we click the sub-title, we only see the demo content like the screenshot of what paste above.

Thanks for your feedback @junezhang

I haven't yet added the content for the seven tiles. I will work on this next. Cheers.

@josemigallas josemigallas changed the base branch from master to UXDENG-57_quick_starts February 24, 2022 10:10
@dfennessy
Copy link
Collaborator Author

@junezhang @deernano @josemigallas

I've added the content, however I'm unsure how to add the tiles for this content via the YAML file.

app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
app/javascript/src/QuickStarts/templates/template.yaml Outdated Show resolved Hide resolved
@josemigallas
Copy link
Contributor

@dfennessy I'm afraid dynamic content isn't possible in YAML. To have it, we'd need to dynamically generate the whole templates from our backend, which would require to implement some logic in Ruby and would make it harder to maintain in the end.
I say if the amount of links is manageable, let's go with hardcoded.

@junezhang
Copy link
Member

junezhang commented Mar 2, 2022

@dfennessy I'm afraid dynamic content isn't possible in YAML. To have it, we'd need to dynamically generate the whole templates from our backend, which would require to implement some logic in Ruby and would make it harder to maintain in the end. I say if the amount of links is manageable, let's go with hardcoded.

If it's hard for the dynamic content, @deernano how do you think to switch to a static link such as the 3scale overview page in the customer portal https://access.redhat.com/products/red-hat-3scale, not a version link?

@dfennessy
Copy link
Collaborator Author

屏幕快照 2022-03-01 下午3 25 03

seems that the ' -' (path) and '1' (4. click to Add to product)are not activated

This looks ok to me at the moment. Maybe it was fixed when I move the Important fields: and indented it properly.

@dfennessy
Copy link
Collaborator Author

dfennessy commented Mar 2, 2022

@junezhang @deernano @josemigallas

I've added the content, however I'm unsure how to add the tiles for this content via the YAML file.

This needs to be addressed, I think. Any ideas?

@junezhang
Copy link
Member

@junezhang @deernano @josemigallas
I've added the content, however I'm unsure how to add the tiles for this content via the YAML file.

This needs to be addressed, I think. Any ideas?

To be honest, I didn't understand what's your meaning of the tiles, we can talk about it in our stand-up meeting.

@dfennessy
Copy link
Collaborator Author

@junezhang @deernano @josemigallas
I've added the content, however I'm unsure how to add the tiles for this content via the YAML file.

This needs to be addressed, I think. Any ideas?

To be honest, I didn't understand what's your meaning of the tiles, we can talk about it in our stand-up meeting.

For example, I've added all the content for template.yaml under Complete a basic API integration. Only one tile appears. We want 8 tiles if there's a separate tile for each....

Base automatically changed from UXDENG-57_quick_starts to master March 11, 2022 10:13
@josemigallas josemigallas had a problem deploying to preview01 March 11, 2022 13:23 Failure
@josemigallas josemigallas had a problem deploying to preview01 March 11, 2022 14:10 Failure
@josemigallas josemigallas had a problem deploying to preview01 March 11, 2022 14:14 Failure
@josemigallas josemigallas temporarily deployed to preview01 March 11, 2022 15:37 Inactive
@josemigallas josemigallas temporarily deployed to preview01 April 11, 2022 09:07 Inactive
@github-actions
Copy link

This PR is stale because it has not received activity for more than 14 days. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 26, 2022
@dfennessy
Copy link
Collaborator Author

Hi @junezhang @deernano @josemigallas

Can this PR be merged soon?

@deernano
Copy link
Contributor

Yes, it is able to merge

@dfennessy
Copy link
Collaborator Author

Yes, it is able to merge

Thanks, Melody.

@josemigallas Please merge 😄

@github-actions github-actions bot removed the Stale label Apr 27, 2022
@josemigallas josemigallas changed the title [WIP] Add content for Quickstarts guides Add content for Quickstarts guides Apr 27, 2022
@josemigallas josemigallas merged commit 493f7a8 into master Apr 27, 2022
@josemigallas josemigallas deleted the 8187-BasicAPIintegration branch April 27, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants