Final touches for Quickstarts

[josemigallas]

What this PR does / why we need it:

Once this PR is merged, we should be able to deploy to master and ship this new feature.

Changes:

• Removes feature config
• Prevent Quickstarts from rendering when not necessary
• Cleanup / Refactor

Which issue(s) this PR fixes
THREESCALE-8283: Integrate Quick Starts into 3scale

[jkeam]

I think you can do something like:

function getActiveQuickstart(): null | string {
  const quickstartId = localStorage.getItem('quickstartId')
  return quickstartId || null
}

From MDN (https://developer.mozilla.org/en-US/docs/Web/API/Storage/getItem), it returns: A string containing the value of the key. If the key does not exist, null is returned.

I don't think there's a need to JSON.parse as it looks like it's an ID you are saving and then retrieving.

And no need to check for length as the getItem call will already return either the string or null if the key does not exist. The reason for the short circuit logic in the return is to catch the edge case of quickstartId being an empty string.

[josemigallas]

Here's the catch: the Patternfly component stores this value as a stringyfied JSON, so the possible values are

undefined
"\"\""
"\"creating-a-method-quick-start\""

So we first need to check if it's a valid JSON and if so, if it's an empty string 😂

I forgot to add some tests, I hope it'll be clearer now

[jkeam]

Ah I see. Then maybe we can make the variable named better? Anything named 'id' is usually a number (or sometimes a string for something like a guid); but in the case of an object, maybe a better name here? Just an idea.