Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final touches for Quickstarts #2962
Final touches for Quickstarts #2962
Changes from all commits
88079dd
470c0ce
567cf3e
d385fa7
7b0a62a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can do something like:
From MDN (https://developer.mozilla.org/en-US/docs/Web/API/Storage/getItem), it returns:
A string containing the value of the key. If the key does not exist, null is returned.
I don't think there's a need to
JSON.parse
as it looks like it's an ID you are saving and then retrieving.And no need to check for length as the
getItem
call will already return either the string or null if the key does not exist. The reason for the short circuit logic in thereturn
is to catch the edge case ofquickstartId
being an empty string.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the catch: the Patternfly component stores this value as a stringyfied JSON, so the possible values are
So we first need to check if it's a valid JSON and if so, if it's an empty string 😂
I forgot to add some tests, I hope it'll be clearer now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. Then maybe we can make the variable named better? Anything named 'id' is usually a number (or sometimes a string for something like a guid); but in the case of an object, maybe a better name here? Just an idea.