Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Fix: Aligning items to the left #300

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

damianpm
Copy link
Contributor

@damianpm damianpm commented Nov 7, 2018

What this PR does / why we need it:

Align items to the left, as they were originally

Special notes for your reviewer:
left-aligned

@damianpm damianpm changed the title [WIP] Quick Fix: Aligning items to the left Quick Fix: Aligning items to the left Nov 7, 2018
@@ -29,6 +29,7 @@
font-weight: $font-weight-bold;
color: $font-color;
float: left;
min-width: 10%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because with a small title, like "API", it looks like:
2aligns

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this also affects the clickable area to fold the API right?

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #300 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   92.58%   92.58%   -0.01%     
==========================================
  Files        2359     2359              
  Lines       75471    75471              
==========================================
- Hits        69875    69874       -1     
- Misses       5596     5597       +1
Impacted Files Coverage Δ
config/initializers/audited_hacks.rb 95.77% <0%> (-1.41%) ⬇️
app/models/payment_transaction.rb 80.64% <0%> (-1.08%) ⬇️
app/helpers/provider/admin/dashboards_helper.rb 87.87% <0%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4152bc...4991f95. Read the comment docs.

@damianpm damianpm changed the title Quick Fix: Aligning items to the left WIP Quick Fix: Aligning items to the left Nov 7, 2018
@damianpm damianpm changed the title WIP Quick Fix: Aligning items to the left Quick Fix: Aligning items to the left Nov 7, 2018
@thomasmaas thomasmaas merged commit ecf1a6a into master Nov 7, 2018
@damianpm damianpm deleted the THREESCALE-1471-Left-Aligned-Items branch November 9, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants