Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Endpoint for Authentication Provider Developer Portal Update also updates site #320

Merged

Conversation

Martouta
Copy link
Contributor

Fixes THREESCALE-1207

:site was documented but not accepted in the strong params.

@Martouta Martouta self-assigned this Nov 13, 2018
@Martouta Martouta requested a review from a team November 13, 2018 13:42
@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #320 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   92.59%   92.59%   -0.01%     
==========================================
  Files        2361     2361              
  Lines       75548    75548              
==========================================
- Hits        69953    69952       -1     
- Misses       5595     5596       +1
Impacted Files Coverage Δ
...s/admin/api/authentication_providers_controller.rb 100% <ø> (ø) ⬆️
config/initializers/audited_hacks.rb 95.77% <0%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c197f9f...cc664f6. Read the comment docs.

@Martouta Martouta merged commit e4bebdc into master Nov 13, 2018
@Martouta Martouta deleted the THREESCALE-1207-authentication-provider-update-site branch November 13, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants