[service] service is not being deleted measures

[macejmic]

related https://github.com/3scale/porta/issues/20

[Martouta]

I don't think this is the problem 🤔

It is normal to thing the events have not been created because they are not in the DB anymore but that may be because we have a Janitor that removes old events (we had to do this because we ended up with a table of 130GB of events before doing this 😂 ):

porta/config/jobs.rb

Line 24 in 6f74cf3

JanitorWorker.perform_async

porta/app/workers/janitor_worker.rb

Line 10 in 4a15c8a

PurgeOldEventsWorker.perform_async

porta/app/workers/purge_old_events_worker.rb

Lines 1 to 14 in 4a15c8a

	# frozen_string_literal: true
	class PurgeOldEventsWorker
	include Sidekiq::Worker
	def perform
	batch = Sidekiq::Batch.new
	batch.description = 'Purge old events'
	batch.jobs do
	EventStore::Event.stale.find_each(&DeletePlainObjectWorker.method(:perform_later))
	end
	end
	end

porta/app/lib/event_store/event.rb

Lines 56 to 58 in 4a15c8a

	TTL = 1.week
	scope :stale, -> { where.has { created_at <= TTL.ago } }

But I don't see where it could have done this action (through a controller) without using the state machine 😄 I suspect the customer used the API to delete the service, since it was used for everything else. Specially the part where they said this after they had already deleted the service:

A delete of the service id 2555417758966 results in 404 error

And if you create a test/events/services/service_scheduled_for_deletion_event_test.rb containing:

require 'test_helper'

class Services::ServiceDeletedEventTest < ActiveSupport::TestCase
  def setup
    @service = FactoryGirl.create(:service)
  end

  attr_reader :service

  def test_destroy_service_publishes_event
    service.mark_as_deleted!
    event = EventStore::Event.where(event_type: 'Services::ServiceScheduledForDeletionEvent').last
    assert_equal service.id, event.data[:service_id]
  end

  def test_after_commit_when_published
    DeletePlainObjectWorker.expects(:perform_later).with do |param|
      param.kind_of?(Service) && param.id == service.id
    end

    event = Services::ServiceScheduledForDeletionEvent.create(service)
    Rails.application.config.event_store.publish_event(event)
  end
end

And btw, it should be DeleteObjectHierarchyWorker instead of DeletePlainObjectWorker for efficiency, which is not the problem here, but since we are on it... 😂

About those tests, you will see the 1st one passes and the 2nd one fails. So I think the problem is the after_commit is being ignored.

So I think we do it with a subscriber instead of the after_commit, like we did with the ServiceTokenDeletedEvent:

• A normal Event, without after_commit:
  

  porta/app/events/service_token_deleted_event.rb

  Lines 1 to 14 in 4a15c8a

  	# frozen_string_literal: true
  	class ServiceTokenDeletedEvent < ServiceTokenRelatedEvent
  	def self.create(service_token)
  	new(
  	id: service_token.id,
  	service_id: service_token.service_id,
  	value: service_token.value,
  	metadata: {
  	provider_id: service_token.account_id || service_token.tenant_id
  	}
  	)
  	end
  	end

• The subscriber listening:
  

  porta/app/lib/event_store/repository.rb

  Line 153 in 4a15c8a

  subscribe_event(ServiceTokenEventSubscriber.new, ServiceTokenDeletedEvent)

• And the subscriber itself doing the job when receives the event:
  

  porta/app/subscribers/service_token_event_subscriber.rb

  Lines 1 to 10 in 4a15c8a

  	# frozen_string_literal: true
  	class ServiceTokenEventSubscriber < AfterCommitSubscriber
  	def after_commit(event)
  	case event
  	when ServiceTokenDeletedEvent then BackendDeleteServiceTokenWorker.enqueue(event)
  	else raise "Unknown event type #{event.class}"
  	end
  	end
  	end

[Martouta]

Awesome! 😍 Thanks! 🥇 💪 💃

[Martouta]

Great job! 🥇 💪