Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip][ci] Use system-builder:2.4 #790

Closed
wants to merge 7 commits into from
Closed

[wip][ci] Use system-builder:2.4 #790

wants to merge 7 commits into from

Conversation

hallelujah
Copy link
Contributor

@hallelujah hallelujah commented May 8, 2019

Closes THREESCALE-2062

  • make tests pass first
  • Keep 2.3 build but schedule a nightly build for 2.4
  • Extract what can be extracted to master

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #790 into master will decrease coverage by 5.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
- Coverage   92.89%   87.85%   -5.05%     
==========================================
  Files        2414     2096     -318     
  Lines       78237    65312   -12925     
==========================================
- Hits        72682    57380   -15302     
- Misses       5555     7932    +2377
Impacted Files Coverage Δ
...ib/three_scale/spam_protection/checks/timestamp.rb 97.95% <100%> (ø) ⬆️
test/unit/array_test.rb 100% <100%> (ø) ⬆️
...pp/controllers/buyers/impersonations_controller.rb 15.38% <0%> (-84.62%) ⬇️
...ollers/provider/admin/api_docs/specs_controller.rb 20% <0%> (-80%) ⬇️
app/controllers/heroku/sessions_controller.rb 22.22% <0%> (-77.78%) ⬇️
...p/controllers/admin/api/heroku_proxy_controller.rb 25% <0%> (-75%) ⬇️
app/helpers/buyers/fields_definitions_helper.rb 25% <0%> (-75%) ⬇️
app/controllers/partners/providers_controller.rb 25% <0%> (-75%) ⬇️
app/helpers/help_bubbles_helper.rb 28.57% <0%> (-71.43%) ⬇️
app/controllers/partners/users_controller.rb 26.66% <0%> (-70%) ⬇️
... and 695 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d050d81...c62ae04. Read the comment docs.

@hallelujah hallelujah requested a review from mikz May 10, 2019 14:34
@hallelujah hallelujah changed the title [wip][ci] Use system-builder:2.4 [ci] Use system-builder:2.4 May 10, 2019
@hallelujah hallelujah requested a review from a team May 10, 2019 14:34
@hallelujah
Copy link
Contributor Author

So @3scale/system I do not know if we should make it run on 2.3 and 2.4 ...

On one hand, it would be no work for @3scale/operations but on the other hand we are going to keep an already dead version

Most of the commits here can be extracted first as single PR into the master branch. I will do that on Monday.

@hallelujah hallelujah changed the title [ci] Use system-builder:2.4 [wip][ci] Use system-builder:2.4 May 13, 2019
@hallelujah
Copy link
Contributor Author

Closing as superseeded by #814

@hallelujah hallelujah closed this May 21, 2019
@hallelujah hallelujah deleted the ruby2.4 branch May 21, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant