Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.4 nightly builds #814

Merged
merged 3 commits into from May 21, 2019
Merged

Ruby 2.4 nightly builds #814

merged 3 commits into from May 21, 2019

Conversation

hallelujah
Copy link
Contributor

@hallelujah hallelujah commented May 21, 2019

Running nightly:

  • mysql + ruby 2.4
  • postgres + ruby 2.4
  • oracle + ruby 2.4

Normal PR are still running on ruby 2.3

Replaces #790
Closes THREESCALE-2062

Note to reviewers.

All nightly builds will run first, if green I will just activate the triggers at midnight.
I will squash some commits too

The commit named "Fix ArgumentError: key must be 32 bytes..." could be extracted to another PR

  • Make every workflow green:
    image

  • Docker build on 2.4

  • Nightly builds on 2.4

@hallelujah hallelujah requested review from gsaslis and a team May 21, 2019 15:43
@hallelujah hallelujah self-assigned this May 21, 2019
@hallelujah hallelujah added Priority: High Closes a JIRA issue in our sprint ruby Pull requests that update Ruby code labels May 21, 2019
We want to migrate so no need to keep ruby 2.3
@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #814 into master will decrease coverage by 0.66%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage    92.9%   92.24%   -0.67%     
==========================================
  Files        2414     2340      -74     
  Lines       78355    75119    -3236     
==========================================
- Hits        72797    69293    -3504     
- Misses       5558     5826     +268
Impacted Files Coverage Δ
...ib/three_scale/spam_protection/checks/timestamp.rb 97.95% <100%> (ø) ⬆️
...ce_discovery/import_cluster_definitions_service.rb 32.3% <0%> (-67.7%) ⬇️
app/lib/stats/views/active_clients.rb 33.33% <0%> (-66.67%) ⬇️
app/lib/three_scale/email_sanitizer.rb 25% <0%> (-66.67%) ⬇️
...b/events/importers/first_daily_traffic_importer.rb 37.5% <0%> (-62.5%) ⬇️
app/helpers/google_experiments_helper.rb 28.57% <0%> (-57.15%) ⬇️
test/test_helpers/events.rb 45.45% <0%> (-54.55%) ⬇️
lib/developer_portal/lib/liquid/wrapper.rb 45.45% <0%> (-50%) ⬇️
app/workers/janitor_worker.rb 50% <0%> (-50%) ⬇️
app/workers/report_traffic_worker.rb 53.33% <0%> (-44.45%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f591474...67ee2aa. Read the comment docs.

@hallelujah hallelujah changed the title [wip] Ruby 2.4 nightly builds Ruby 2.4 nightly builds May 21, 2019
@@ -2,7 +2,7 @@ module ThreeScale::SpamProtection
module Checks

class Timestamp < Base
DEFAULT_SECRET_KEY = -> { Rails.application.key_generator.generate_key('spam-protection-checks-timestamp') }
DEFAULT_SECRET_KEY = -> { Rails.application.key_generator.generate_key('spam-protection-checks-timestamp', 32) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I asked Hery and he said:

because openssl on ruby 2.4 is not accepting more than 32 bytes secret

@hallelujah hallelujah merged commit 1cf212f into master May 21, 2019
@hallelujah hallelujah deleted the nightly-ruby2.4-build branch May 21, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Closes a JIRA issue in our sprint ruby Pull requests that update Ruby code
Projects
None yet
3 participants