New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 2.4 nightly builds #814
Conversation
72e2afe
to
0481a52
Compare
We want to migrate so no need to keep ruby 2.3
0481a52
to
67ee2aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
==========================================
- Coverage 92.9% 92.24% -0.67%
==========================================
Files 2414 2340 -74
Lines 78355 75119 -3236
==========================================
- Hits 72797 69293 -3504
- Misses 5558 5826 +268
Continue to review full report at Codecov.
|
@@ -2,7 +2,7 @@ module ThreeScale::SpamProtection | |||
module Checks | |||
|
|||
class Timestamp < Base | |||
DEFAULT_SECRET_KEY = -> { Rails.application.key_generator.generate_key('spam-protection-checks-timestamp') } | |||
DEFAULT_SECRET_KEY = -> { Rails.application.key_generator.generate_key('spam-protection-checks-timestamp', 32) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I asked Hery and he said:
because openssl on ruby 2.4 is not accepting more than 32 bytes secret
Running nightly:
Normal PR are still running on ruby 2.3
Replaces #790
Closes THREESCALE-2062
Note to reviewers.
All nightly builds will run first, if green I will just activate the triggers at midnight.
I will squash some commits too
The commit named "Fix ArgumentError: key must be 32 bytes..." could be extracted to another PR
Make every workflow green:
Docker build on 2.4
Nightly builds on 2.4