Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge first beta build of 2.13 into beta-testing #168

Merged
merged 144 commits into from
May 5, 2023
Merged

Merge first beta build of 2.13 into beta-testing #168

merged 144 commits into from
May 5, 2023

Conversation

3urobeat
Copy link
Owner

@3urobeat 3urobeat commented May 5, 2023

The first beta build should be ready. It features a complete rework of the internal structure to prepare for the upcoming plugin system and improve code quality as a whole.

@3urobeat 3urobeat added BETA BETA version related, does not seem to affect master New Version labels May 5, 2023
global.checkm8="b754jfJNgZWGnzogvl<rsHGTR4e368essegs9<";

// Check if owner link is correct
if (!this.config.owner.includes("steamcommunity.com")) {

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization

'[steamcommunity.com](1)' can be anywhere in the URL, and arbitrary hosts may come before or after it.
data.forEach((e) => {
if (e.length < 2) return; // If the line is empty ignore it to avoid issues like this: https://github.com/HerrEurobeat/steam-comment-service-bot/issues/80
e = e.split(":");
e[e.length - 1] = e[e.length - 1].replace("\r", ""); // Remove Windows next line character from last index (which has to be the end of the line)

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding

This replaces only the first occurrence of "\r".
.replace(/"\[/g, "[")
.replace(/\]"/g, "]")
.replace(/\\"/g, '"')
.replace(/""/g, '""');

Check failure

Code scanning / CodeQL

Replacement of a substring with itself

This replaces '""' with itself.
.replace(/"\[/g, "[")
.replace(/\]"/g, "]")
.replace(/\\"/g, '"')
.replace(/""/g, '""');

Check failure

Code scanning / CodeQL

Replacement of a substring with itself

This replaces '""' with itself.
.replace(/"\[/g, "[")
.replace(/\]"/g, "]")
.replace(/\\"/g, '"')
.replace(/""/g, '""');

Check failure

Code scanning / CodeQL

Replacement of a substring with itself

This replaces '""' with itself.
.replace(/"\[/g, "[")
.replace(/\]"/g, "]")
.replace(/\\"/g, '"')
.replace(/""/g, '""');

Check failure

Code scanning / CodeQL

Replacement of a substring with itself

This replaces '""' with itself.
.replace(/"\[/g, "[")
.replace(/\]"/g, "]")
.replace(/\\"/g, '"')
.replace(/""/g, '""');

Check failure

Code scanning / CodeQL

Replacement of a substring with itself

This replaces '""' with itself.
@3urobeat 3urobeat merged commit 46a35ca into beta-testing May 5, 2023
@3urobeat 3urobeat deleted the v13 branch May 5, 2023 15:06
@Beyulium
Copy link

Beyulium commented May 5, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BETA BETA version related, does not seem to affect master New Version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants