Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tfsec top level workflow permissions #57

Merged
merged 3 commits into from
Mar 16, 2023
Merged

fix: tfsec top level workflow permissions #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
372930a
set `persist-credentials: true` in tfsec workflow
chris3ware Mar 16, 2023
0d66f3e
change top level permissions to `contents: read` in terraform-docs
chris3ware Mar 16, 2023
afb49c3
add `check: write` to lint
chris3ware Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ jobs:

lint:
runs-on: ubuntu-latest
permissions:
checks: write # not required (see slack) but produces an error in the logs
# https://trunkcommunity.slack.com/archives/C04GAE5EA5S/p1677846825881319?thread_ts=1676214812.584879&cid=C04GAE5EA5S
timeout-minutes: 10
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref }}
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/terraform-docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ name: Generate terraform docs
on: workflow_call

# Declare default permissions as read only.
permissions: read-all
permissions:
contents: read

jobs:
get-temp-token:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tfsec-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Checkout repository
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
with:
persist-credentials: false
persist-credentials: true # tfsec step fails when false

- name: Add tfsec comments to pull request
uses: aquasecurity/tfsec-pr-commenter-action@7a44c5dcde5dfab737363e391800629e27b6376b # v1.3.1
Expand Down