Update Roamer mode to use new navigation functions #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes calls to the deprecated same-map navigation function in favour of the new cross-map one. Doing that simplifies the code a little bit, and hopefully also fixes 40Cakes#316 (at least I wasn't able to reproduce the behaviour anymore.) As a semi-related fix, this resolves an issue where reapplying Repel would lead to the player continue running in the same direction until they hit an obstacle.
40Cakes
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes calls to the deprecated same-map navigation function in favour of the new cross-map one.
Doing that simplifies the code a little bit, and hopefully also fixes #316 (at least I wasn't able to reproduce the behaviour anymore.)
As a semi-related fix, this resolves an issue where reapplying Repel would lead to the player continue running in the same direction until they hit an obstacle.
Changes
modules/map_path.py- Fix a bug where the bot would crash if map object data wasn't fully loaded yet by the game.modules/modes/util/items.py- Fix the bug where the player would stuck running in one direction after re-applying Repel.modules/modes/roamer_reset.py- Migrated navigation functions.Checklist
--line-length 120argument