Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roamers FRLG throwing errors seems at random at the start of the loop #316

Closed
johnnieb333 opened this issue Apr 19, 2024 · 1 comment · Fixed by #318 or #326
Closed

Roamers FRLG throwing errors seems at random at the start of the loop #316

johnnieb333 opened this issue Apr 19, 2024 · 1 comment · Fixed by #318 or #326

Comments

@johnnieb333
Copy link

NVIDIA_Share_38Rmj31KQ7
it seems to happen at random times , 2 users Red_mana and Corazon brought it to my attention I let the bot run for longer then 10 loops and got the same error
hanzi added a commit to hanzi/pokebot-gen3 that referenced this issue May 7, 2024
@hanzi
Update Roamer mode to use new navigation functions
b84b0bf 
This removes calls to the deprecated same-map navigation function in favour of the new cross-map one.

Doing that simplifies the code a little bit, and hopefully also fixes 40Cakes#316 (at least I wasn't able to reproduce the behaviour anymore.)

As a semi-related fix, this resolves an issue where reapplying Repel would lead to the player continue running in the same direction until they hit an obstacle.
hanzi added a commit to hanzi/pokebot-gen3 that referenced this issue May 7, 2024
@hanzi
Update Roamer mode to use new navigation functions
b5f2b0d 
This removes calls to the deprecated same-map navigation function in favour of the new cross-map one.

Doing that simplifies the code a little bit, and hopefully also fixes 40Cakes#316 (at least I wasn't able to reproduce the behaviour anymore.)

As a semi-related fix, this resolves an issue where reapplying Repel would lead to the player continue running in the same direction until they hit an obstacle.
@hanzi hanzi mentioned this issue May 7, 2024
Merged
2 tasks
hanzi added a commit to hanzi/pokebot-gen3 that referenced this issue May 7, 2024
@hanzi
Update Roamer mode to use new navigation functions
896aed5 
This removes calls to the deprecated same-map navigation function in favour of the new cross-map one.

Doing that simplifies the code a little bit, and hopefully also fixes 40Cakes#316 (at least I wasn't able to reproduce the behaviour anymore.)

As a semi-related fix, this resolves an issue where reapplying Repel would lead to the player continue running in the same direction until they hit an obstacle.
@hanzi hanzi closed this as completed in #318 May 8, 2024
@hanzi
Copy link
Collaborator

hanzi commented May 10, 2024

Sadly, it's been reported to still happen after the fix.

@hanzi hanzi reopened this May 10, 2024
hanzi added a commit to hanzi/pokebot-gen3 that referenced this issue May 10, 2024
@hanzi
Fix occasional 'player avatar is currently not controllable' error in…
2cccdc7 
… FR/LG roamer reset mode

Fixes 40Cakes#316
@hanzi hanzi mentioned this issue May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hanzi @johnnieb333