Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes from hackathon #39

Merged
merged 2 commits into from
May 27, 2023
Merged

Some changes from hackathon #39

merged 2 commits into from
May 27, 2023

Conversation

svetlyak40wt
Copy link
Member

Changed

  • Function REBLOCKS/ACTIONS:MAKE-JS-ACTION now accepts ARGS argument. If given, it will be serialized as a dictionary and embedded into the action calling code. This way you can pass the arguments back into your lisp callback.

Added

  • Added includeCSS and includeJS command handlers. This makes it possible to send such kind of commands via a websocket.
  • Now all widgets rendered on a page are collected into a hash table and you can find them by dom-id using REBLOCKS/PAGE:FIND-WIDGET-BY-ID function.

Changed
=======

* Function REBLOCKS/ACTIONS:MAKE-JS-ACTION now accepts ARGS argument. If given, it will be serialized as a dictionary and embedded into the action calling code. This way you can pass the arguments back into your lisp callback.

Added
=====

* Added `includeCSS` and `includeJS` command handlers. This makes it possible to send such kind of commands via a websocket.
* Now all widgets rendered on a page are collected into a hash table and you can find them by dom-id using REBLOCKS/PAGE:FIND-WIDGET-BY-ID function.
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5101170709

  • 7 of 60 (11.67%) changed or added relevant lines in 9 files are covered.
  • 39 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.5%) to 26.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/widget.lisp 0 1 0.0%
src/doc/page.lisp 0 2 0.0%
src/widgets/render-methods.lisp 1 3 33.33%
src/page-dependencies.lisp 0 5 0.0%
src/welcome/widget.lisp 0 5 0.0%
src/page.lisp 5 14 35.71%
src/server.lisp 0 13 0.0%
src/actions.lisp 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
src/app.lisp 1 39.37%
src/page.lisp 1 29.64%
src/server.lisp 1 0%
src/welcome/widget.lisp 2 0%
src/session.lisp 4 13.33%
src/hooks.lisp 30 70.76%
Totals Coverage Status
Change from base Build 4630764605: -0.5%
Covered Lines: 2110
Relevant Lines: 8080

💛 - Coveralls

@svetlyak40wt svetlyak40wt merged commit 16765fa into master May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant