Added support for secret-values in weblocks-auth/github:*secret*.

40ants · Jan 24, 2021 · ed4cfc6 · ed4cfc6
1 parent c5f1c8d
commit ed4cfc6
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/ChangeLog.rst b/ChangeLog.rst
@@ -2,6 +2,11 @@
  ChangeLog
 ===========
 
+0.6.0
+=====
+
+* Added support for ``secret-values`` in ``weblocks-auth/github:*secret*``.
+
 0.5.1
 =====
 

diff --git a/src/github.lisp b/src/github.lisp
@@ -21,6 +21,8 @@
                 #:url-encode-params)
   (:import-from #:weblocks/request
                 #:get-uri)
+  (:import-from #:secret-values
+                #:ensure-value-revealed)
   (:export
    #:*client-id*
    #:*secret*
@@ -36,7 +38,7 @@
 
 
 (defvar *secret* nil
-  "OAuth secret")
+  "OAuth secret. It might be a string or secret-values:secret-value.")
 
 
 (defvar *default-scopes* (list "user:email"))
@@ -60,7 +62,8 @@
   (let* ((response (dex:post "https://github.com/login/oauth/access_token"
                              :content (to-json (list :|code| code
                                                      :|client_id| *client-id*
-                                                     :|client_secret| *secret*))
+                                                     :|client_secret| (ensure-value-revealed
+                                                                       *secret*)))
                              :headers '(("Accept" . "application/json")
                                         ("Content-Type" . "application/json"))))
          (data (jonathan:parse response))

diff --git a/version.lisp-expr b/version.lisp-expr
@@ -1 +1 @@
-"0.4.0"
+"0.6.0"