This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
**No bounty** Fix Path traversal vulnerability on Snek Serv #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📊 Metadata *
Bounty was not set but still worth fixing and send trough huntr
The
snekserve
project is adirectory listing
server which is vulnerable against Directory Traversal, which may allow access to sensitive files and data on the server.For example, requesting the following URL:
/../../etc/passwd
would result in/etc/passwd
leaking.Bounty URL: No bounty, just to get it fixed
⚙️ Description *
There is no path sanitization in the path provided making marscode vulnerable against path traversal through the ../ technique, leading to information exposure and file content disclosure.
💻 Technical Description *
Fixed by sanitizing any occurrence of ../, using regexp.
🐛 Proof of Concept (PoC) *
node index.js
curl -v --path-as-is http://127.0.0.1:8080/../../../../../../../../../../../etc/passwd
Proof of Fix (PoF) *
After fix Response code 400 Bad request is returned to user instead of restricted file conten
👍 User Acceptance Testing (UAT)
After fix functionality is unafected