Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve tests suite #76

Merged
merged 1 commit into from
Jun 8, 2022
Merged

test: Improve tests suite #76

merged 1 commit into from
Jun 8, 2022

Conversation

42atomys
Copy link
Owner

@42atomys 42atomys commented Jun 8, 2022

Describe the pull request
Some part of applications are not correctly tested. I have add some tests and reworks some tests

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
no

Additional context

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #76 (b222ea4) into main (a06b045) will increase coverage by 2.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   90.36%   92.79%   +2.43%     
==========================================
  Files          22       22              
  Lines         944      944              
==========================================
+ Hits          853      876      +23     
+ Misses         70       50      -20     
+ Partials       21       18       -3     
Impacted Files Coverage Δ
internal/server/v1alpha1/handlers.go 92.94% <100.00%> (+23.52%) ⬆️
pkg/storage/rabbitmq/rabbitmq.go 81.25% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06b045...b222ea4. Read the comment docs.

@42atomys 42atomys merged commit ca02870 into main Jun 8, 2022
@42atomys 42atomys deleted the test/improve_tests branch June 8, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants