-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add LitElement to recommended config #118
Conversation
Introducing the `invalid-extends` rule into the best practice config resulted in a larger breaking change than expected: LitElement repos fail to lint without introducing an `elementBaseClasses` setting. Since a large chunk of our consumers are lit users, it makes sense to add it to the recommended config so it doesn't need configuring individually.
@keithamus what do you think about this? i'm torn on one hand, it'd save people time since they can upgrade without many config changes. on the other, it means error messages in non-lit repos will say things like basically without this it means many consumers will have to introduce a i suppose the ideal is a lit config, but im just trying to think of a way to make the migration a bit easier (from 1.x to 2.x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR is fine as is but I also wonder - could we use heuristics to determine if its a lit project, e.g. reading from package.json?
i did wonder that too, maybe we could get away with just otherwise, we could look for a edit: i've updated this to use the require.resolve method, let me know if you think that'll be fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great!
Introducing the
invalid-extends
rule into the best practice config resulted in a larger breaking change than expected: LitElement repos fail to lint without introducing anelementBaseClasses
setting.Since a large chunk of our consumers are lit users, it makes sense to add it to the recommended config so it doesn't need configuring individually.