Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (no-child-traversal-in-connectedcallback): new rule #89

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

43081j
Copy link
Owner

@43081j 43081j commented Jun 11, 2023

same as the one for attribute changed callback, but for connectedCallback

basically disallows child traversals in there

Copy link
Collaborator

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@43081j 43081j merged commit 87d0cc9 into ce-next-attrchange Jul 16, 2023
5 checks passed
43081j added a commit that referenced this pull request Jul 16, 2023
* feat (no-child-traversal-in-attributechangedcallback): new rule

* feat (no-child-traversal-in-connectedcallback): new rule (#89)
@43081j 43081j deleted the ce-next-connected branch July 16, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants