cleanup

43081j · Aug 6, 2020 · 039402e · 039402e
1 parent a9f15c4
commit 039402e
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/lighthouse-core/lib/page-functions.js b/lighthouse-core/lib/page-functions.js
@@ -171,9 +171,14 @@ function ultradumbBenchmark() {
  */
 /* istanbul ignore next */
 function getNodePath(node) {
+  // For our purposes, there's no worthwhile difference between shadow root and document fragment
+  // We can consider them entirely synonymous.
+  const isShadowRoot = node => node.nodeType === Node.DOCUMENT_FRAGMENT_NODE;
+  const getNodeParent = node => isShadowRoot(node) ? node.host : node.parentNode;
+
   /** @param {Node} node */
   function getNodeIndex(node) {
-    if (node.nodeType === Node.DOCUMENT_FRAGMENT_NODE) {
+    if (isShadowRoot(node)) {
       // User-agent shadow roots get 'u'. Non-UA shadow roots get 'a'.
       return 'a';
     }
@@ -188,10 +193,6 @@ function getNodePath(node) {
     return index;
   }
 
-  function getNodeParent(node) {
-    return node.nodeType === Node.DOCUMENT_FRAGMENT_NODE ? node.host : node.parentNode
-  }
-
   const path = [];
   while (node && !!getNodeParent(node)) {
     const index = getNodeIndex(node);