Friendly amendments to pull #15 #17
Conversation
Not all current NodeJS installs return "node" when checking
`process.argv[0]`.
On my system it returns:
$ node -p -e 'process.argv[0]'
/Users/glenn/.nvm/versions/node/v4.2.2/bin/node
Do the sniff-test of whether we are running tests in a browser or
in node a different way.
An example of previous fail was:
```
/Users/glenn/src/miniLockLib/library.compiled/readSliceOfData.js:17
this.fileReader = new FileReader;
^
ReferenceError: FileReader is not defined
at EncryptOperation.module.exports [as readSliceOfData] (/Users/glenn/src/miniLockLib/library.compiled/readSliceOfData.js:17:31)
at EncryptOperation.module.exports.EncryptOperation.encryptData (/Users/glenn/src/miniLockLib/library.compiled/EncryptOperation.js:161:19)
at EncryptOperation.module.exports.EncryptOperation.run (/Users/glenn/src/miniLockLib/library.compiled/EncryptOperation.js:85:19)
at EncryptOperation.module.exports.EncryptOperation.start (/Users/glenn/src/miniLockLib/library.compiled/EncryptOperation.js:78:16)
at EncryptOperation.start (/Users/glenn/src/miniLockLib/library.compiled/EncryptOperation.js:4:59)
at Object.miniLockLib.encrypt (/Users/glenn/src/miniLockLib/library.compiled/index.js:19:22)
at /Users/glenn/src/miniLockLib/tests.compiled/A Few Demo Tests.js:15:26
at /Users/glenn/src/miniLockLib/tests.compiled/fixtures.js:50:14
at Object.read.files.basic.txt (/Users/glenn/src/miniLockLib/tests.compiled/fixtures.js:56:14)
at exports.read (/Users/glenn/src/miniLockLib/tests.compiled/fixtures.js:46:28)
```
…ADME. Revised the introduction of the Digging In section to explain that GNU Make and Node.js are the basic software requirements for fiddling with the miniLockLib code. Removed pointer to “brew install …” because i don’t like alcohol or the command line.
…t’s why i am removing it. Reverts commit 3d06d2f
Running `make` works on my computer when the browserify package is installed locally with `npm`. i am willing to consider other options if this doesn’t work predictably on other computers.
|
Hi, glad you are still there. I guess its intentional that you are trying to completely obfuscate your identity and association with this lib? ;-) Regarding Pow. It would not work for me with a clean install on OS X El Capitan. There are a lot of comments on several Pow issues related to this: basecamp/pow#452 The last commit to Pow repo was in 2014. It is fair to consider it abandoned and non-functional due to significant changes by Apple in the OS X releases since 2014. https://github.com/basecamp/pow/commits/master Caddy is a super simple replacement web server. It really doesn't matter what you use I suppose, maybe even a simple python command to run a local server. But please don't leave to Pow instructions in place. e.g. According to the browserify site it should be installed as a global since it provides a system wide binary: docco should also be installed global according to their docs (again with the rule of binary's being installed globally, and packages you will require being installed locally): Thanks again for responding and looking carefully. Glenn |
|
Thanks for pointing out the abandon-ed-ness of Pow. i didn’t know about any of that stuff. i will phase it out of this project to guard against anymore confusion. Rather than add install instructions and config for Caddy, i decided to add the 'http-server' package to the development dependencies in the master branch (ede5997) so that everything required to run the tests is available after To start up the default webserver to facilitate the window tests type |
|
thanks for bringing up the issue about installing packages globally @grempe. i see that docco and browserify recommend a global install but i don’t want to recommend it for the miniLockLib setup procedure. they both work good for me as local development dependencies and i would prefer to keep the setup procedure uncomplicated. i just want to of course, if that flow is problematic for you i'm willing to reconsider. for now i'm going to leave it unmentioned in the README i think. |
|
Sounds good. I was not particularly tied to Caddy. Just suggesting a working replacement. Your solution sounds fine. I'll try it out. Also fine for docco and browserify, as long as they work just installed locally. :-) G |
Hi @grempe, here are some amendments to the changes you pushed in pull request #15.
If these are ok with you i will merge them into the master branch. Or feel free to make some suggestions for additional changes.
Thank you again for your work on this. Kind regards.