Update README.md, fix test bug, update depends, replace broken Pow!, no curl to get libs #15
Conversation
Not all current NodeJS installs return "node" when checking
`process.argv[0]`.
On my system it returns:
$ node -p -e 'process.argv[0]'
/Users/glenn/.nvm/versions/node/v4.2.2/bin/node
Do the sniff-test of whether we are running tests in a browser or
in node a different way.
An example of previous fail was:
```
/Users/glenn/src/miniLockLib/library.compiled/readSliceOfData.js:17
this.fileReader = new FileReader;
^
ReferenceError: FileReader is not defined
at EncryptOperation.module.exports [as readSliceOfData] (/Users/glenn/src/miniLockLib/library.compiled/readSliceOfData.js:17:31)
at EncryptOperation.module.exports.EncryptOperation.encryptData (/Users/glenn/src/miniLockLib/library.compiled/EncryptOperation.js:161:19)
at EncryptOperation.module.exports.EncryptOperation.run (/Users/glenn/src/miniLockLib/library.compiled/EncryptOperation.js:85:19)
at EncryptOperation.module.exports.EncryptOperation.start (/Users/glenn/src/miniLockLib/library.compiled/EncryptOperation.js:78:16)
at EncryptOperation.start (/Users/glenn/src/miniLockLib/library.compiled/EncryptOperation.js:4:59)
at Object.miniLockLib.encrypt (/Users/glenn/src/miniLockLib/library.compiled/index.js:19:22)
at /Users/glenn/src/miniLockLib/tests.compiled/A Few Demo Tests.js:15:26
at /Users/glenn/src/miniLockLib/tests.compiled/fixtures.js:50:14
at Object.read.files.basic.txt (/Users/glenn/src/miniLockLib/tests.compiled/fixtures.js:56:14)
at exports.read (/Users/glenn/src/miniLockLib/tests.compiled/fixtures.js:46:28)
```
grempe
changed the title
|
Any chance of this being pulled upstream? I've heard nothing from @45678 on this pull request. Thx! |
|
ping? @45678 |
|
Thank you for working through these changes @grempe. And thank you for pursuing them with me for such an unreasonably long time. It is a very kind gesture. Thank you. i haven’t been on the computer in a long time and that’s why i haven’t followed up with you. i am sorry that i didn’t notice this earlier because i know that you were left wondering – in limbo – for a long time. i haven’t looked at the commits in detail yet but i will check them out later today or tomorrow morning. From the outside looking in they look great. Thanks again. i will follow up with here you tomorrow. Again, i am sorry about leaving you in limbo for so long. Kind regards. |
| @@ -1,4 +1,4 @@ | |||
| if process?.argv?[0] is "node" | |||
| if typeof window is "undefined" | |||
There was a problem hiding this comment.
Perfect, thank you for sorting this out @grempe.
|
Thanks for pulling in the changes. Look forward to trying it out. |
|
No problem @grempe. i was expecting more of your commits to show up in the master branch log. i don’t know how to use git and GitHub very well so i probably could have done the merge better to preserve more of your commits and due credit. anyway, sorry about that. please do let me know if you run into any trouble with the master branch. |
|
As far as I can tell all of my commits made it to master. I was able to cleanly delete my branch (which git would not let me do if there were unmerged changes). Thanks. Hope these changes help the next guy. If there were a way to contact you out-of-band (twitter, email, whatever) that would have been helpful too :-) The new web server changes work fine for me. Better than Pow. Cheers, Glenn |
Fix a few issues I ran across when testing this locally. POW server is no longer supported for current versions of OS X, replaced with Caddy server. Updated all NPM dependencies. Fixed a bug where sniff-test for FileReader was not working for some node installations, scrypt-async is in NPM now, no need to pull in from head of master branch with curl, regenerated compiled files with latest version of coffescript.