Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sbt-org-policies to 0.7.4 #164

Merged
merged 2 commits into from Sep 21, 2017
Merged

Bump sbt-org-policies to 0.7.4 #164

merged 2 commits into from Sep 21, 2017

Conversation

BenFradet
Copy link
Contributor

@BenFradet BenFradet commented Sep 17, 2017

It also migrates from cats 0.9.0 to 1.0.0-MF, among other upgrades and enhancements.

@codecov-io
Copy link

codecov-io commented Sep 17, 2017

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files          40       40           
  Lines         606      606           
  Branches        3        3           
=======================================
  Hits          531      531           
  Misses         75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec8322...b5cd021. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This setting would be only for badge purposes. If we want to bump to the latest version of Scalajs, we need to bump up also the sbt-org-policies version: https://github.com/47deg/sbt-org-policies/releases/tag/v0.6.3

@BenFradet BenFradet changed the title Bump scala js version to 0.6.19 Bump scala js version to 0.6.20 Sep 18, 2017
@BenFradet
Copy link
Contributor Author

Thanks, I wasn't entirely sure sbt-org-policies needed to be involved, I'll take care of 47degrees/sbt-org-policies#538 as well then.

@juanpedromoreno
Copy link
Member

@BenFradet I needed to upgrade sbt-org-policies and btw I upgraded everything in general: 47degrees/sbt-org-policies#632, including Scalajs.

@BenFradet
Copy link
Contributor Author

Thanks a lot! I'll bump sbt-org later today 👍

@BenFradet BenFradet force-pushed the bf-scala-js-0.6.19 branch 2 times, most recently from fe87a32 to 842f6cd Compare September 18, 2017 18:15
@BenFradet
Copy link
Contributor Author

mmmh getting https://travis-ci.org/47deg/github4s/jobs/276970366#L846 with 0.6.4 and sbt doesn't launch with 0.7.0

@suhasgaddam
Copy link
Contributor

suhasgaddam commented Sep 18, 2017

@BenFradet I think Scala.js 0.6.20 requires sbt 0.13.16.
with
sbt-org-policies:0.7.0
build.properties: sbt.version = 0.13.16

sbt +compile seems to work for me, locally

Links that I stumbled on and for anyone else searching:
https://stackoverflow.com/questions/46206462/java-lang-nosuchmethoderror-sbt-package-zerolsbt-global
http://www.scala-js.org/news/2017/09/01/announcing-scalajs-0.6.20/ -> Breaking Changes

Release notes for sbt 0.13.16:
https://github.com/sbt/sbt/releases/tag/v0.13.16

@suhasgaddam
Copy link
Contributor

The travis ci error: sbt-org-policies:0.6.4 did not have sbt-microsites enabled. We are/were still working on getting sbt-microsites cross-compiling with sbt 1.0.

@BenFradet
Copy link
Contributor Author

@suhasgaddam thanks! didn't know about the issue with microsites / 0.13.16 min for 0.6.20

@BenFradet BenFradet force-pushed the bf-scala-js-0.6.19 branch 2 times, most recently from b5de641 to a24d0cf Compare September 18, 2017 21:01
addSbtPlugin(
"com.47deg" % "sbt-org-policies" % "0.5.4" exclude ("io.get-coursier", "sbt-coursier"))
"com.47deg" % "sbt-org-policies" % "0.6.4" exclude ("io.get-coursier", "sbt-coursier"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 0.7.0 0.7.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 😨

@BenFradet BenFradet force-pushed the bf-scala-js-0.6.19 branch 2 times, most recently from 4e82e36 to 68dcd6b Compare September 19, 2017 08:13
@BenFradet
Copy link
Contributor Author

Weirdly enough it seems to compile fine even though cats.data.Coproduct was removed from cats-1.0.0-MF.

However, it fails during the cats-effect tests with https://travis-ci.org/47deg/github4s/jobs/277197841#L2596.

Still investigating 😕

@BenFradet BenFradet changed the title Bump scala js version to 0.6.20 Bump sbt-org-policies to 0.7.4 Sep 21, 2017
@BenFradet
Copy link
Contributor Author

@juanpedromoreno fixed! 👍 Regarding releasing a version, do I just need to edit version.sbt? Should I introduce a specific commit?

@juanpedromoreno
Copy link
Member

Yes, you only need to modify the version.sbt.

Are we releasing the 0.1.5.1 or 0.16.0? As it's not binary compatible I propose 0.16.0, what do you think?

Either way, I'd suggest doing it in a different PR, since due to 47degrees/sbt-org-policies#637, the plugin is not running the release task correctly. Hence, we might need to edit the orgAfterSuccessCI task by something like this https://github.com/47deg/sbt-org-policies/blob/2c89b98d9366b626a978e3ff17cbc25e561ea48b/.travis.yml#L31-L44, in the .travis.yml file.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, outstanding work.

@BenFradet
Copy link
Contributor Author

BenFradet commented Sep 21, 2017

@juanpedromoreno ok thanks 👍 , I'll open a new PR

yes, I agree that 0.16.0 makes more sense btw

@BenFradet BenFradet merged commit ebfc312 into master Sep 21, 2017
@BenFradet BenFradet deleted the bf-scala-js-0.6.19 branch September 21, 2017 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants