Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish v0.7.13? #248

Closed
SethTisue opened this issue Dec 13, 2017 · 3 comments
Closed

publish v0.7.13? #248

SethTisue opened this issue Dec 13, 2017 · 3 comments

Comments

@SethTisue
Copy link

SethTisue commented Dec 13, 2017 •
edited

it would be nice to have a release with the #247 fix

my own context for wanting it is scala/community-build#645
@SethTisue SethTisue mentioned this issue Dec 13, 2017
Merged
@suhasgaddam
Copy link
Contributor

Should the SettingKeys in https://github.com/47deg/sbt-microsites/blob/master/project/KazariBuild.scala also be changed to settingKey?

@SethTisue
Copy link
Author

@suhasgaddam they could, but I don't think it matters. the bad code that #247 fixed was using big-S-SettingKey but only passing one string. it's fine to use big-S-SettingKey as long as you pass two strings (the key name & the description)

@juanpedromoreno juanpedromoreno mentioned this issue Dec 14, 2017
Merged
@juanpedromoreno
Copy link
Member

@SethTisue Done! #249

@suhasgaddam I did the change for the sake of consistency.

dwijnand added a commit to scala/community-build that referenced this issue Dec 14, 2017
@dwijnand
Unfork circe
8955966 
No longer need to use the fork with coursier removed (#629) or sbt-microsite upgraded (47degrees/sbt-microsites#248 + circe/circe#803).
@dwijnand dwijnand mentioned this issue Dec 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SethTisue @juanpedromoreno @suhasgaddam