Use settingKey for SettingKey definitions #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
approved these changes
Dec 10, 2017
|
Thanks, Travis. |
|
at first glance I thought this must be an sbt bug, but now I think the old code here was just wrong and it's good that sbt now catches it. |
Closed
|
Indeed, I see it as grey zone as well. sbt 1.1 shouldn't really cause an exception to be thrown, even if it's made strides to transition keys from the old "kebab-case" to camelCase, however the code here was also simply "wrong". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure exactly how
SettingKey.applychanged such that these definitions result in "A named attribute key must start with a lowercase letter" errors on sbt 1.1.0-RC1, but usingsettingKeyfixes the issue and is more consistent, anyway.