Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New style redesign #354

Merged
merged 27 commits into from
Nov 4, 2019
Merged

New style redesign #354

merged 27 commits into from
Nov 4, 2019

Conversation

AntonioMateoGomez
Copy link
Contributor

This PR implements the new Sbt-microsites design wich we have named light. We also keep the classic pattern style and we provide the option to generate it aswell.
Documentation has change to describe how to set any of these two styles.
We remove bootstrap from the new style, also we change the default highlight theme as atelier-forest-light.

We are still not changing the version.sbt file to do it in a next PR to launch the next release, once done so, we must to change the plugins.sbt file so sbt-microsites will display the new light style.

Fixes #334

Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to specify that Jekyll 4.0.0 at least is required to be installed on the system

@israelperezglez
Copy link
Contributor

israelperezglez commented Oct 28, 2019

Good Job @AntonioMateoGomez , I add some comments:

  • Links should have a :hover
  • Could we pick another Theme for highlight.js?
  • In the sidebar we could add a :hover in the li a
  • #masthead .text-center doesn't work in responsive. width: 750px --> max-width: 750px

Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the page layout:

https://47deg.github.io/sbt-microsites/docs/layouts.html#page-layout-and-menu-partial-layout

We need to:

  • Either specify that the page layout is not supported for the new default light theme. Also, this will be important to remark in any version release announcement, as it could break sites like Scalaz, Cats, or fs2 ones.

  • Either support this layout on the new default theme. Maybe we can even simply make a quick translation of the new home including the horizontal navbar.

Thoughts on this @juanpedromoreno, @AntonioMateoGomez, @israelperezglez? If we had to vote I'd try to go with the latter option 🙂

s"View on ${config.gitSettings.gitHostingService.name}")
)
),
"{% include menu.html %}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes all light Home layouts include a menu when they shoudln't 🤷‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's present in the old pattern theme, and ideally we could be fixing it there too, but at least we shouldn't be dragging those bugs to the new themes.

This is what this generates in a usecase of a single Home layout, an unnecessary empty ul:

image

@AntonioMateoGomez AntonioMateoGomez merged commit 57706d0 into master Nov 4, 2019
@AntonioMateoGomez AntonioMateoGomez deleted the paolo-334-new-style-redesign branch November 4, 2019 14:55
@AntonioMateoGomez AntonioMateoGomez restored the paolo-334-new-style-redesign branch November 5, 2019 08:42
@AntonioMateoGomez AntonioMateoGomez deleted the paolo-334-new-style-redesign branch November 5, 2019 08:44
@calvellido calvellido mentioned this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sbt-microsite style redesign
3 participants