Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accuracy and grade #28

Closed
wants to merge 0 commits into from
Closed

Conversation

uzervlad
Copy link
Contributor

@uzervlad uzervlad commented Nov 2, 2023

I assume calculating accuracy should be faster than reading from memory

src/structs.rs Outdated Show resolved Hide resolved
@MaxOhn
Copy link
Contributor

MaxOhn commented Nov 2, 2023

One downside of calculating things manually is that it likely increases the final binary size a little. Can't say by how much but it should maybe be checked and factored into the decision whether this should be merged.

Another big factor for the decision is of course the performance difference so that could be benchmarked.

@486c
Copy link
Owner

486c commented Nov 6, 2023

Calculating acc & grade by ourself gonna be faster than any syscall to OS, especially when we talking about linux.
@uzervlad could you rebase/merge newer changes from master + add trace spans, if you don't mind. if not i'm gonna do it myself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants