-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency fork-ts-checker-webpack-plugin to v5 #213
Conversation
@jquense might be good to switch to this at some point; it's a big enough API change though that i can't quite take care of this just as a matter of course |
the migration here got annoying |
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. If you think this comment is in error and the branch is not modified, try deleting this comment. If it comes back again the next time Renovate runs, please submit an issue or seek config help. |
|
||
const options = index !== -1 ? plugins[index].options : {}; | ||
|
||
const plugin = new ForkTsCheckerWebpackPlugin({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the way this structured now i can't monkey patch it so we need to just find and replace the plugin before it's applied
log({ | ||
name: '4c/start', | ||
level: 'silent', | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private API here, to finally shut WDS up
typeof error.message === 'string' && | ||
error.message.startsWith('\nUnusedFilesWebpackPlugin') | ||
typeof message === 'string' && | ||
message.startsWith('\nUnusedFilesWebpackPlugin') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these were broken
module.exports = (error) => { | ||
const message = error.message || get(error, 'webpackError'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why isn't this just
const message = error.message || get(error, 'webpackError'); | |
const message = error.message || error.webpackError; |
@@ -4,15 +4,14 @@ const formatErrors = require('friendly-errors-webpack-plugin/src/core/formatErro | |||
const transformErrors = require('friendly-errors-webpack-plugin/src/core/transformErrors'); | |||
const colors = require('friendly-errors-webpack-plugin/src/utils/colors'); | |||
// eslint-disable-next-line import/no-extraneous-dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: this was meant to apply to webpack
below
|
||
const plugin = new ForkTsCheckerWebpackPlugin({ | ||
...options, | ||
async: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this effectively true by default now when running in dev mode?
This PR contains the following updates:
^4.0.0
->^5.0.5
Release Notes
TypeStrong/fork-ts-checker-webpack-plugin
v5.0.5
Compare Source
Bug Fixes
v5.0.4
Compare Source
Bug Fixes
v5.0.3
Compare Source
Bug Fixes
v5.0.2
Compare Source
v5.0.1
Compare Source
v5.0.0
Compare Source
This is a major release that includes the plugin rewrite 🚀
The options format changed and is documented in the README.md.
Features
context
option for typescript reporter (#430) (a430979), closes #297version
const for external tools (#428) (37b8944)BREAKING CHANGES
issue.scope
option.v4.1.6
Compare Source
v4.1.5
Compare Source
Bug Fixes
failed
hook (#415) (77effc8), closes #411v4.1.4
Compare Source
Code Refactoring
v4.1.3
Compare Source
Bug Fixes
v4.1.2
Compare Source
Bug Fixes
v4.1.1
Compare Source
Bug Fixes
v4.1.0
Compare Source
Features
v4.0.5
Compare Source
Bug Fixes
v4.0.4
Compare Source
Bug Fixes
v4.0.3
Compare Source
Bug Fixes
v4.0.2
Compare Source
Bug Fixes
Renovate configuration
📅 Schedule: "before 2am" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.