Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency fork-ts-checker-webpack-plugin to v5 #213

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 25, 2020

This PR contains the following updates:

Package Type Update Change
fork-ts-checker-webpack-plugin dependencies major ^4.0.0 -> ^5.0.5

Release Notes

TypeStrong/fork-ts-checker-webpack-plugin

v5.0.5

Compare Source

Bug Fixes

v5.0.4

Compare Source

Bug Fixes

v5.0.3

Compare Source

Bug Fixes

v5.0.2

Compare Source

v5.0.1

Compare Source

v5.0.0

Compare Source

This is a major release that includes the plugin rewrite 🚀
The options format changed and is documented in the README.md.

Features
BREAKING CHANGES
  • 🧨 Issues outside webpack compilation will not be reported by default. See issue.scope option.
  • 🧨 Dropped support for Node 6 and Node 8
  • 🧨 Changed options format
  • 🧨 Changed plugin hooks
  • 🧨 Minimum TypeScript >=2.7.0

v4.1.6

Compare Source

v4.1.5

Compare Source

Bug Fixes

v4.1.4

Compare Source

Code Refactoring

v4.1.3

Compare Source

Bug Fixes

v4.1.2

Compare Source

Bug Fixes

v4.1.1

Compare Source

Bug Fixes
  • add a warning message for SIGINT (4013a3f)

v4.1.0

Compare Source

Features

v4.0.5

Compare Source

Bug Fixes

v4.0.4

Compare Source

Bug Fixes
  • prevent null-pointer error after killing child process (642b5bf), closes #​363

v4.0.3

Compare Source

Bug Fixes
  • change import of crypto (1c82006)

v4.0.2

Compare Source

Bug Fixes

Renovate configuration

📅 Schedule: "before 2am" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@taion
Copy link
Contributor

taion commented Jun 26, 2020

@jquense might be good to switch to this at some point; it's a big enough API change though that i can't quite take care of this just as a matter of course

@jquense jquense requested a review from taion July 1, 2020 19:32
@jquense
Copy link
Member

jquense commented Jul 1, 2020

the migration here got annoying

@renovate
Copy link
Contributor Author

renovate bot commented Jul 1, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

If you think this comment is in error and the branch is not modified, try deleting this comment. If it comes back again the next time Renovate runs, please submit an issue or seek config help.


const options = index !== -1 ? plugins[index].options : {};

const plugin = new ForkTsCheckerWebpackPlugin({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way this structured now i can't monkey patch it so we need to just find and replace the plugin before it's applied

log({
name: '4c/start',
level: 'silent',
}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private API here, to finally shut WDS up

typeof error.message === 'string' &&
error.message.startsWith('\nUnusedFilesWebpackPlugin')
typeof message === 'string' &&
message.startsWith('\nUnusedFilesWebpackPlugin')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were broken

module.exports = (error) => {
const message = error.message || get(error, 'webpackError');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: why isn't this just

Suggested change
const message = error.message || get(error, 'webpackError');
const message = error.message || error.webpackError;

@@ -4,15 +4,14 @@ const formatErrors = require('friendly-errors-webpack-plugin/src/core/formatErro
const transformErrors = require('friendly-errors-webpack-plugin/src/core/transformErrors');
const colors = require('friendly-errors-webpack-plugin/src/utils/colors');
// eslint-disable-next-line import/no-extraneous-dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: this was meant to apply to webpack below


const plugin = new ForkTsCheckerWebpackPlugin({
...options,
async: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this effectively true by default now when running in dev mode?

@jquense jquense merged commit 58001f8 into master Jul 6, 2020
@jquense jquense deleted the renovate/fork-ts-checker-webpack-plugin-5.x branch July 6, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants