Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include typescript declarations in npm package #178

Merged
merged 3 commits into from
Apr 27, 2018

Conversation

rosskevin
Copy link
Contributor

Closes #177

Typescript declarations need to be copied to distributable.

@taion
Copy link
Contributor

taion commented Apr 26, 2018

@rosskevin I tweaked this a bit... moved index.d.ts to root. Is this okay?

@taion
Copy link
Contributor

taion commented Apr 26, 2018

This is how I see things set up for Redux, so maybe it's a more common way to do this?

@rosskevin
Copy link
Contributor Author

That's fine, some are in src when they are split into multiple files, otherwise it can be anywhere.

@taion
Copy link
Contributor

taion commented Apr 26, 2018

Do we need to tweak tsconfig.json to make this work?

@rosskevin
Copy link
Contributor Author

I pushed a tsconfig fix after the index.d.ts location change.

@taion
Copy link
Contributor

taion commented Apr 27, 2018

Great, thanks!

@taion taion merged commit f05d4bb into 4Catalyzer:master Apr 27, 2018
@taion
Copy link
Contributor

taion commented Apr 27, 2018

v0.3.11

@rosskevin rosskevin deleted the package-typescript branch September 4, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants