Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore is failing sometimes due to v0.2.0's Phantom File fix #9

Closed
jeffschwartz opened this issue Jul 9, 2018 · 0 comments
Closed

Restore is failing sometimes due to v0.2.0's Phantom File fix #9

jeffschwartz opened this issue Jul 9, 2018 · 0 comments
Assignees
@jeffschwartz
Labels
bug Something isn't working
Milestone
v0.2.1

Comments

@jeffschwartz
Copy link
Collaborator

When restoring, gob will return files already hashed because they match the original name. The v0.2.0 fix for this isn't working and now can cause restore to fail. The v0.2.0 fix was ill advised and a new fix that eliminates phantom files earlier in restore process is needed.
@jeffschwartz jeffschwartz added the bug Something isn't working label Jul 9, 2018
@jeffschwartz jeffschwartz added this to the v0.2.1 milestone Jul 9, 2018
@jeffschwartz jeffschwartz self-assigned this Jul 9, 2018
jeffschwartz added a commit that referenced this issue Jul 10, 2018
@jeffschwartz
now eliminating phantom files when restoring in hashFileNames()
48235e7 
addresses issue #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffschwartz jeffschwartz

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.1
Development

No branches or pull requests
1 participant
@jeffschwartz