Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help test.sh fail, and remove source? #143

Closed
mccalluc opened this issue Sep 19, 2018 · 0 comments
Closed

Help test.sh fail, and remove source? #143

mccalluc opened this issue Sep 19, 2018 · 0 comments

Comments

@mccalluc
Copy link
Contributor

Without set -e, only the status from the last line in test.sh is going to matter.

$ bash

$ cat /tmp/not-failing.sh 
#!/bin/bash
false
echo 'still got here!'

$ source /tmp/not-failing.sh 
still got here!

$ cat /tmp/failing.sh 
#!/bin/bash
set -e
false
echo 'still got here!'

$ source /tmp/failing.sh 

$ 

... and, if we add set -e, it's probably better not to use source: It's better to be explicit about what needs to be exported to a script, and I think set -e can confuse Travis: they have internal scripts which return non-zero status, but which aren't really problems.

PR coming soon...

@SooLee SooLee closed this as completed in b67861d Sep 19, 2018
SooLee added a commit that referenced this issue Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant