Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc changes related to SMaHT ingestion. #292

Merged
merged 8 commits into from
Nov 2, 2023
Merged

Misc changes related to SMaHT ingestion. #292

merged 8 commits into from
Nov 2, 2023

Conversation

dmichaels-harvard
Copy link
Contributor

No description provided.

willronchetti
willronchetti approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@willronchetti willronchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment worth checking

dcicutils/bundle_utils.py Outdated
Comment on lines 661 to 662
return checked_items, problems
error_summary = summary_of_data_validation_errors(problems)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this return statement intended? Dead code beneath it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual dead code - deleted

@coveralls
Copy link

coveralls commented Nov 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6736515053

  • 17 of 24 (70.83%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 78.593%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dcicutils/bundle_utils.py 5 6 83.33%
dcicutils/validation_utils.py 10 11 90.91%
dcicutils/ff_utils.py 2 7 28.57%
Files with Coverage Reduction New Missed Lines %
dcicutils/bundle_utils.py 1 89.77%
Totals Coverage Status
Change from base Build 6710569342: 0.008%
Covered Lines: 9340
Relevant Lines: 11884
💛 - Coveralls

@dmichaels-harvard dmichaels-harvard merged commit 15e795f into master Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willronchetti willronchetti willronchetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmichaels-harvard @coveralls @willronchetti