Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License addition for pyinstaller; experimenting with this in submitr #310

Merged
merged 5 commits into from
Jun 24, 2024
Merged

License addition for pyinstaller; experimenting with this in submitr #310

merged 5 commits into from
Jun 24, 2024

Conversation

dmichaels-harvard
Copy link
Contributor

@dmichaels-harvard dmichaels-harvard commented Jun 11, 2024 •
edited
Loading

  • Changes related to pyinstaller experimentation for smaht-submitr.
    Mostly changing calls to exit to sys.exit; and related license_utils change.
  • Added hook to structured_data (row_reader_hook) for integration testing purposes.

@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9469389307

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.657%
Totals Coverage Status
Change from base Build 9467512300: 0.0%
Covered Lines: 11350
Relevant Lines: 15002
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9484083091

Details

  • 3 of 15 (20.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 75.648%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dcicutils/progress_bar.py 0 1 0.0%
dcicutils/deployment_utils.py 0 2 0.0%
dcicutils/ecr_scripts.py 0 4 0.0%
dcicutils/env_scripts.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
dcicutils/env_scripts.py 1 0.0%
Totals Coverage Status
Change from base Build 9467512300: -0.009%
Covered Lines: 11351
Relevant Lines: 15005
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9508054407

Details

  • 5 of 18 (27.78%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 75.671%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dcicutils/progress_bar.py 0 1 0.0%
dcicutils/structured_data.py 2 3 66.67%
dcicutils/deployment_utils.py 0 2 0.0%
dcicutils/ecr_scripts.py 0 4 0.0%
dcicutils/env_scripts.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
dcicutils/env_scripts.py 1 0.0%
Totals Coverage Status
Change from base Build 9484732102: -0.01%
Covered Lines: 11368
Relevant Lines: 15023
💛 - Coveralls

dmichaels-harvard
dmichaels-harvard commented Jun 14, 2024
View reviewed changes
dcicutils/structured_data.py
@@ -57,6 +57,7 @@ def __init__(self, file: Optional[str] = None, portal: Optional[Union[VirtualApp
ref_lookup_nocache: bool = False,
norefs: bool = False, merge: bool = False,
progress: Optional[Callable] = None,
row_reader_hook: Optional[Callable] = None,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to pyinstaller changes.

@dmichaels-harvard dmichaels-harvard changed the title License addition for pyinstaller; experimenting with this in smaht-su… License addition for pyinstaller; experimenting with this in submitr Jun 14, 2024
@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9650087514

Details

  • 5 of 18 (27.78%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 75.671%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dcicutils/progress_bar.py 0 1 0.0%
dcicutils/structured_data.py 2 3 66.67%
dcicutils/deployment_utils.py 0 2 0.0%
dcicutils/ecr_scripts.py 0 4 0.0%
dcicutils/env_scripts.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
dcicutils/env_scripts.py 1 0.0%
Totals Coverage Status
Change from base Build 9484732102: -0.01%
Covered Lines: 11368
Relevant Lines: 15023
💛 - Coveralls

@dmichaels-harvard dmichaels-harvard merged commit 24a456a into master Jun 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willronchetti willronchetti willronchetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmichaels-harvard @coveralls @willronchetti